Adds Statuser implementation #88
Conversation
proximo/internal/proximoc/client.go
Outdated
| return base64.URLEncoding.EncodeToString(random) | ||
| } | ||
|
|
||
| func (p *ProducerConn) GrpcClient () *grpc.ClientConn { |
There was a problem hiding this comment.
exported method ProducerConn.GrpcClient should have comment or be unexported
There was a problem hiding this comment.
also it should be GRPCClient although it looks a bit worse
https://stackoverflow.com/questions/39830166/glued-acronyms-and-golang-naming-convention
proximo/status.go
Outdated
| return nil, ErrNotConnected | ||
| } | ||
|
|
||
| var working bool |
There was a problem hiding this comment.
var (
working bool
problems []string
)
switch cc.GetState() {looks better imho
|
Looks good, but do you maybe want to try using substrate instead? https://github.com/uw-labs/substrate It gives you basically the same api with synchronous adapters, but you can also use the async version if you need better throughput. We did a bit of work there recently, so it might be hopefully better behaved than this old client... |
The same was suggested by @thinktainer and implementation is on the way. Question then is do we still want this added here for possible future use? |
|
I think, it's fine to merge, we just want to encourage people to use substrate more |
4 participants
No description provided.