Skip to content

Conversation

@jonasbardino
Copy link
Contributor

Force Show Peers date to display on same format as the date picker by wrapping it in a dummy input field without border.
Limit date picker UI and backend accepted date range to dates between 7 days from today and ~10 years in the future, with fallback to default 365 days if an invalid value is given. Highlight the fallback in output. The end date value is automatically interpreted as until midnight and the defaults are now read from mig/shared/defaults.py both for UI and backend.

@jonasbardino jonasbardino self-assigned this Nov 4, 2025
@jonasbardino jonasbardino added the enhancement New feature or request label Nov 4, 2025
@jonasbardino
Copy link
Contributor Author

Lint errors are from old unrelated code and should be fixed by PR #386 .

@jonasbardino jonasbardino marked this pull request as ready for review November 4, 2025 11:13
@jonasbardino
Copy link
Contributor Author

Verified on one of our test deployments.

@jonasbardino jonasbardino requested a review from a team November 4, 2025 11:13
@aputtu
Copy link

aputtu commented Nov 4, 2025

Tested with focus on adherence to:

  1. Naming convention, changing "Expire" to "End Date" in Show Peers tab. This allows us to distinguish account expiry in relation to automated renewals from the end date that peer contact sets as a hard limit to access
  2. Ability to set minimum and maximum end dates; ie. respectively 7 days and 10 years from current date.

Tested with Ubuntu 24.04 (Wayland, dark mode).

Naming in Show Peers needs adjustment ⛔
Needs adjustment on tabs: Show Peers, Enter Peers, and Import Peers (Not tested Requested Peers)
image

Minimum end date should be current date + 7 days ✔️
Screenshot from 2025-11-04 12-01-27

Maximum end date should be current date + 10 years ✔️
Screenshot from 2025-11-04 12-29-46

@jonasbardino
Copy link
Contributor Author

Thanks for thorough testing and review 👍
This PR is against the main branch so it doesn't have the 'Expire' -> 'End date' naming fixes of PR #384, yet, but once merged we will get both the naming and the consistency fixes in the main branch.

… wrapping

it in a dummy input field without border.
Limit date picker UI and backend accepted date range to dates between 7 days
from today and ~10 years in the future, with fallback to default 365 days if
an invalid value is given. Highlight the fallback in output.
The end date value is automatically interpreted as until midnight and the
defaults are now read from mig/shared/defaults.py both for UI and backend.
@jonasbardino jonasbardino force-pushed the adjust/peers-to-use-consistent-date-format-and-limit-range branch from 81178ce to 5b953d8 Compare November 4, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants