Skip to content

Conversation

@jonasbardino
Copy link
Contributor

Add the missing docstrings to the mig/shared/fileio.py unit tests as follow up to PR #48.
Minor comment clean up and line length adjustment from autopep8.

…ollow up

to PR48. Minor comment clean up and line length adjustment from autopep8.
@jonasbardino jonasbardino self-assigned this Nov 1, 2025
@jonasbardino jonasbardino added refactor Non-functional changes to simplify or clean up test-only Improvements or additions solely for better test coverage - without functionality changes labels Nov 1, 2025
@jonasbardino jonasbardino requested a review from a team November 1, 2025 13:09
Copy link
Contributor

@albu-diku albu-diku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm not great at docstrings, but adding one per test is something of a new requirement and I think is a little too much.

What has been written in those strings is an improvement that should be to the test name itself --that is what shows up on the command line when tests fail. I can't think of a reason we would opt to have non-descriptive test names and then a sperate string that clarifies what the test is checking.

Again, I'm not going to insist and it's not my call to make regarding the standards, so am voicing that I don't believe this to be a good idea for tests.

@jonasbardino
Copy link
Contributor Author

I know I'm not great at docstrings, but adding one per test is something of a new requirement and I think is a little too much.

What has been written in those strings is an improvement that should be to the test name itself --that is what shows up on the command line when tests fail. I can't think of a reason we would opt to have non-descriptive test names and then a sperate string that clarifies what the test is checking.

Again, I'm not going to insist and it's not my call to make regarding the standards, so am voicing that I don't believe this to be a good idea for tests.

The changes were really only in order to add the missing mandatory docstrings on classes and non-obvious functions as per the old TODO comment.
It's not a requirement for trivial functions or self-explaining test methods, and in this case I got them for free when I just asked aider to fix docstrings because I couldn't be bothered.
The docstring shows up in the output as user friendly explanation when a test fails so it's not completely pointless, but I agree that test names themselves should in most cases suffice.

@jonasbardino jonasbardino merged commit 8e7c396 into next Nov 18, 2025
7 checks passed
@jonasbardino jonasbardino deleted the adjust/add-missing-docstrings-to-fileio-unit-tests-as-pr48-follow-up branch November 18, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Non-functional changes to simplify or clean up test-only Improvements or additions solely for better test coverage - without functionality changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants