Fix expand hasMany relationship
#1542
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_expandquery param would work with abelongsTorelationship but not withhasManyrelationship.For this db.json:
{ "posts": [{ "id": 1, "title": "My post title", "userId": 2, "tags": [1, 2] }], "users": [...], "tags": [...] }This
posts/3?_expand=userwork since the post has auserIdforeign key as"userId" : 2, it's just abelongsTorelationship, butposts/3?_expand=tagswill not work since it will look fortagsIdproperty inside thepost, and deal with the value as a number not number[], so expect"tagsId": nnot"tagsId": [x, y, z].Updating the
expandfunction fixes this issue, now it will check first if the key exists in the resource, so check first for"tags"beforetagsId, means before adding theIdsuffix:Then check if its value is an array, e.g.
"tags": [1, 2]