Prefer immutable.Seq and Iterable #393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There was a strange issue where def f[T](a: collection.mutable.ArrayBuffer[T]):collection.mutable.Seq[T] = {
if (a.isEmpty) collection.mutable.Seq.empty[T]
else a.to[collection.mutable.Seq]
}
f: [T](a: collection.mutable.ArrayBuffer[T])collection.mutable.Seq[T]Seemingly, this was because |
ashawley
commented
Apr 5, 2018
| import Prop.Arg | ||
|
|
||
| import scala.collection.immutable.Seq | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is because Test.checkProperties return type is defined as Seq[(String,Result)].
ashawley
force-pushed
the
immutable-seq
branch
4 times, most recently
from
13d9510 to
6a8015b
Compare
Contributor
Author
|
I didn't realize MiMa was disabled until #399 put it back. Turns out there are a lot of compatibility changes if |
Preparation for the new collections library. Cherry-picked from work on trying to: Add support for Scala 2.13-M4
Fix by removing parens.
The collections library doesn't do this automatically. Seemingly, this is because org.scalacheck.util.SerializableCanBuildFroms has implicits that interfere.
ashawley
force-pushed
the
immutable-seq
branch
2 times, most recently
from
a8d9b13 to
88c291d
Compare
- method oneOf(Seq)Gen in object Gen's type is different in current version, where it is (immutable.Seq)Gen instead of (Seq)Gen - method sequence(Traversable,util.Buildable)Gen in object Gen's type is different in current version, where it is (Iterable,util.Buildable)Gen instead of (Traversable,util.Buildable)Gen - method properties()Seq in class Properties has a different result type in current version, where it is immutable.Seq rather than Seq - method checkProperties(Test#Parameters,Properties)Seq in object Test has a different result type in current version, where it is immutable.Seq rather than Seq - method canCreateNewSut(java.lang.Object,Traversable,Traversable)Boolean in interface commands.Commands's type is different in current version, where it is (java.lang.Object,Iterable,Iterable)Boolean instead of (java.lang.Object,Traversable,Traversable)Boolean - abstract method canCreateNewSut(java.lang.Object,Iterable,Iterable)Boolean in interface commands.Commands is present only in current version - method fromIterable(Traversable)java.lang.Object in interface util.Buildable's type is different in current version, where it is (Iterable)java.lang.Object instead of (Traversable)java.lang.Object
- method fromIterable(Traversable)java.lang.Object in trait util.Buildable does not have a correspondent in current version - method fromIterable(Iterable)java.lang.Object in trait util.Buildable is present only in current version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the vaunted 2.13 collections library changes, I've cherry-picked a few of Julien Richard-Foy's changes in his 2.13.0-M4 porting work in #391. In the interest of better understanding the impending 2.13 release changes, it would be good to at least make piecewise progress.
Julien was looking at using the scala-collections-compat library and preserving the internal uses of
mutable.Seq. I investigated just switching to usingimmutable.Seqand making the switch fromTraversabletoIterable.These changes don't seem very onerous and they seem to work across multiple Scala versions and targets (including js and native).