feat: add embedding response caching support #273
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcallender
commented
Nov 20, 2025
bcallender
commented
- Add FenicEmbeddingsResponse type
- Update CachedResponse to support both completions and embeddings
- Add ResponseType enum for type safety
- Implement embedding cache key computation
- Update SQLite schema to store embeddings
- Update ModelClient to handle embedding caching
- Add comprehensive tests for embedding caching
This was referenced Nov 20, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
…to ensure cache is being used on actual queries
- Add FenicEmbeddingsResponse type - Update CachedResponse to support both completions and embeddings - Add ResponseType enum for type safety - Implement embedding cache key computation - Update SQLite schema to store embeddings - Update ModelClient to handle embedding caching - Add comprehensive tests for embedding caching
bcallender
force-pushed
the
feat/llm-caching
branch
from
dcbe6ee to
79ea09b
Compare
bcallender
force-pushed
the
feat/embedding-caching
branch
from
c17aa9b to
ff01bf4
Compare
bcallender
force-pushed
the
feat/llm-caching
branch
10 times, most recently
from
422b203 to
f696333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.