Skip to content
This repository was archived by the owner on Jun 26, 2022. It is now read-only.

Commit b68b27a

Browse files
authored
Update usage of rules_antlr (#2)
## What is the goal of this PR? Eliminate possible inconsistencies by loading ANTLR version from a constant ## What are the changes implemented in this PR? Pass a constant from `vaticle_dependencies` to `rules_antlr`
1 parent 077ce7c commit b68b27a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

WORKSPACE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ load("@vaticle_dependencies//builder/python:deps.bzl", python_deps = "deps")
4848
python_deps()
4949

5050
# Load //builder/antlr
51-
load("@vaticle_dependencies//builder/antlr:deps.bzl", antlr_deps = "deps")
51+
load("@vaticle_dependencies//builder/antlr:deps.bzl", antlr_deps = "deps", "antlr_version")
5252
antlr_deps()
5353

5454
load("@rules_antlr//antlr:lang.bzl", "JAVA")
5555
load("@rules_antlr//antlr:repositories.bzl", "rules_antlr_dependencies")
56-
rules_antlr_dependencies("4.7.2", JAVA)
56+
rules_antlr_dependencies(antlr_version, JAVA)
5757

5858
# Load //tool/common
5959
load("@vaticle_dependencies//tool/common:deps.bzl", "vaticle_dependencies_ci_pip",

dependencies/vaticle/repositories.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def vaticle_dependencies():
2525
git_repository(
2626
name = "vaticle_dependencies",
2727
remote = "https://github.com/vaticle/dependencies",
28-
commit = "81520f0787ce5e78935144241b66c3b02bf7ed5d", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
28+
commit = "3a58ebd1f1e249b21b8d8bd07c7415d127aa9dc1", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
2929
)
3030

3131
def vaticle_typeql():

0 commit comments

Comments
 (0)