Implement/Derive (de)serialization instances needed for test file #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninioArtillero
force-pushed
the
ninioArtillero/json-instances
branch
from
f098597 to
110bd18
Compare
ninioArtillero
force-pushed
the
ninioArtillero/json-instances
branch
from
2a1c03c to
fde4cf8
Compare
ninioArtillero
commented
Nov 17, 2025
Comment on lines
+125
to
+136
| instance (ToJSON a, ToJSON b) => ToJSON (AnchoredSeq v a b) where | ||
| toJSON anchoredSeq = | ||
| object | ||
| [ "anchor" .= anchor anchoredSeq | ||
| , "sequence" .= toOldestFirst anchoredSeq | ||
| ] | ||
|
|
||
| instance (Anchorable v a b, FromJSON a, FromJSON b) => FromJSON (AnchoredSeq v a b) where | ||
| parseJSON = withObject "AnchoredSeq" $ \obj -> do | ||
| a <- obj .: "anchor" | ||
| s <- obj .: "sequence" | ||
| pure $ fromOldestFirst a s |
Collaborator
Author
There was a problem hiding this comment.
I used the AnchoredSeq interface to implement the instances, instead of going down to StrictFingerTree as suggested. The reason being that I found no way of deconstructing it and leverage the StrictFingerTree instance.
ninioArtillero
commented
Nov 17, 2025
Comment on lines
+17
to
+18
| -- Note that most of the constraints in this instance declarations are caused | ||
| -- by the abstraction of the block type parameter. |
Collaborator
Author
There was a problem hiding this comment.
At this point I've just made this compile. Still need to test that we can DO serialize a concrete block (the TestBlock I guess).
isovector
approved these changes
Nov 18, 2025
| (ToJSON (HeaderHash blk), HasHeader blk, ToJSON schedule, ToJSON blk) => | ||
| ToJSON (GenesisTest blk schedule) | ||
| where | ||
| toEncoding = genericToEncoding defaultOptions |
Collaborator
There was a problem hiding this comment.
why does this instance have toEncoding but the others do not?
Collaborator
Author
There was a problem hiding this comment.
Figure I would be returning later to implement a custom instance, so it's like a little queue.
isovector
pushed a commit
that referenced
this pull request
Nov 19, 2025
# Description Closes tweag/cardano-conformance-testing-of-consensus#52 This PR creates a separate module to accommodate the (orphan) instances needed to serialize/deserialize a `GenesisTest` as JSON; we take this approach to avoid spreading changes throughout the codebase during this phase of development. As specified in our design, `conformance-test-runner` consumes a test file that specifies (at least) a `PointSchedule` to run. It turns out our peer simulator would need access to the whole of a `GenesisTest` data, which will contain the `PointSchedule` in particular. In #3, the relevant instances were introduced for the `PointSchedule`alone. All this changes are moved into the aforementioned module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes tweag/cardano-conformance-testing-of-consensus#52
This PR creates a separate module to accommodate the (orphan) instances needed to serialize/deserialize a
GenesisTestas JSON; we take this approach to avoid spreading changes throughout the codebase during this phase of development.As specified in our design,
conformance-test-runnerconsumes a test file that specifies (at least) aPointScheduleto run.It turns out our peer simulator would need access to the whole of a
GenesisTestdata, which will contain thePointSchedulein particular.In #3, the relevant instances were introduced for the
PointSchedulealone. All this changes are moved into the aforementioned module.