Skip to content

Replace url.parse with URL constructor #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Replace url.parse with URL constructor #817

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08614b6
Replace url.parse with URL constructor
riderx Nov 18, 2025
490e795
Remove outdated comments in NodeHttpStack.ts
riderx Nov 18, 2025
9bda268
Fix URL construction in Request class
riderx Nov 18, 2025
0874d45
Fix spread operator usage in Request class URL options
riderx Nov 18, 2025
a8337f0
Refactor URL handling in Request class to use URL constructor for bet…
riderx Nov 18, 2025
4143a9b
Refactor Request class to simplify URL handling in send method
riderx Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/node/NodeHttpStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// The url.parse method is superseeded by the url.URL constructor,
// but it is still included in Node.js
import * as http from 'node:http'
import * as https from 'node:https'
import { Readable, Transform, type Writable } from 'node:stream'
import { parse } from 'node:url'
import isStream from 'is-stream'
import throttle from 'lodash.throttle'
import type {
Expand Down Expand Up @@ -91,8 +88,8 @@ class Request implements HttpRequest {
}

return new Promise((resolve, reject) => {
const url = new URL(this._url)
const options = {
...parse(this._url),
...this._requestOptions,

method: this._method,
Expand All @@ -109,8 +106,8 @@ class Request implements HttpRequest {
options.headers['Content-Length'] = body.size
}

const httpModule = options.protocol === 'https:' ? https : http
this._request = httpModule.request(options)
const httpModule = url.protocol === 'https:' ? https : http
this._request = httpModule.request(url, options)
const req = this._request
req.on('response', (res) => {
const resChunks: Buffer[] = []
Expand Down
Loading