-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add OpenRouter detector #4500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add OpenRouter detector #4500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrt to the fmt changes, I can revert them, not sure which fmt I have enabled atm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not update this file. You need to add the detector enum to the detectors.proto and then run make protos for the new changes to reflect in this file.
More details here: https://github.com/trufflesecurity/trufflehog/blob/main/hack/docs/Adding_Detectors_external.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I did something wrong, mb will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
f436f10 to
8cee242
Compare
c192f0c to
8cee242
Compare
|
Hey @shahzadhaider1, lmk if there's anything needed from me to move this PR forward! |
Hey @McPatate, thank you for the contribution. It looks good, but we’re currently pausing the addition of new detectors. We’ll get this merged once we’ve refined our process for maintaining them. |
|
Ok thanks for letting me know! Do you have an idea of the timeline wrt to:
? |
|
Thanks for your patience @McPatate -- we're kicking around ideas for getting this merged in a stable fashion. I should have more for you soon; hopefully today. |
closes #4499
Description:
Adds the OpenRouter detector as discussed in #4499.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note: I ran
make lintand I'm seeing quite the list of warnings, although none related to the changes I made afaict. Is this safe to ignore?