Skip to content

Conversation

@koszti
Copy link
Member

@koszti koszti commented Oct 13, 2025

Description

This PR replaces HTML and custom CSS with Material UI (MUI) components and theme styling. No functional/behavioral changes, this is a purely visual/layout refactor to make visual consistency of the app with the main Trino preview UI and other projects in the trino ecosystem.

What changed

  • Replaced HTML markup and custom CSS styles with MUI components (AppBar, Box, Typography, Table, etc.).
  • Centralized styling via the MUI theme for consistent spacing, typography, and colors
  • Support dark and light theme
  • Drop all custom CSS files

Screenshots
image

image

Additional context and related issues

Usage / Embedding
The editor is embeddable into other react projects, e.g.:

<QueryEditor theme="dark" height={800} />

Out of scope::

  • Move legacy React patterns to modern hooks and idioms.
  • Evaluate/transition to the official trino-js-client for server communication.

@cla-bot cla-bot bot added the cla-signed label Oct 13, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @koszti, your pull request is larger than the review limit of 150000 diff characters

@koszti
Copy link
Member Author

koszti commented Oct 13, 2025

@mosabua just a heads up - this works and I wanted to park it here as the next potential item to review. Let's make #21 ready first. It’s a large change because I couldn’t reasonably split. After all is now visually consistent with the preview UI by using material UI.

@koszti koszti force-pushed the material-ui branch 2 times, most recently from 50342f8 to e8bf3ab Compare October 13, 2025 22:19
@mosabua
Copy link
Member

mosabua commented Nov 4, 2025

This is great but I think we need to preserve the current version in a binary release first. Now that the other PR is merged we have to get this rebased anyway .. can you send a PR for a release first though?

@sajjoseph
Copy link

@koszti - hope you are still working on it. I look forward to see this feature merged so that we can incorporate into Trino UI. That will be a day to celebrate! Love your work and looking forward to see further enhancements in the UI layers.

@koszti koszti changed the title Switch to Material UI; replaced custom CSS/HTML with MUI components (no functional changes) Switch to Material UI Nov 9, 2025
@koszti koszti force-pushed the material-ui branch 4 times, most recently from 3d5f246 to f3f66b6 Compare November 9, 2025 11:14
@koszti
Copy link
Member Author

koszti commented Nov 9, 2025

@mosabua rebase completed.

can you send a PR for a release first though?

I don't think a PR is required for the release. Creating it on the release page in GitHub should trigger the release action to publish it to npm. Have you tried that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants