-
Notifications
You must be signed in to change notification settings - Fork 8
Switch to Material UI #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @koszti, your pull request is larger than the review limit of 150000 diff characters
50342f8 to
e8bf3ab
Compare
|
This is great but I think we need to preserve the current version in a binary release first. Now that the other PR is merged we have to get this rebased anyway .. can you send a PR for a release first though? |
|
@koszti - hope you are still working on it. I look forward to see this feature merged so that we can incorporate into Trino UI. That will be a day to celebrate! Love your work and looking forward to see further enhancements in the UI layers. |
3d5f246 to
f3f66b6
Compare
…no functional changes)
|
@mosabua rebase completed.
I don't think a PR is required for the release. Creating it on the release page in GitHub should trigger the release action to publish it to npm. Have you tried that? |
Description
This PR replaces HTML and custom CSS with Material UI (MUI) components and theme styling. No functional/behavioral changes, this is a purely visual/layout refactor to make visual consistency of the app with the main Trino preview UI and other projects in the trino ecosystem.
What changed
AppBar,Box,Typography,Table, etc.).Screenshots

Additional context and related issues
Usage / Embedding
The editor is embeddable into other react projects, e.g.:
Out of scope::
trino-js-clientfor server communication.