Replace system::time::Duration with std::time::Duration
#1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jul 22, 2025
joriskleiber
force-pushed
the
replace-duration
branch
2 times, most recently
from
562b268 to
9f08633
Compare
joriskleiber
force-pushed
the
replace-duration
branch
from
9f08633 to
928dd57
Compare
bjorn3
requested changes
Nov 26, 2025
Collaborator
bjorn3
left a comment
bjorn3
left a comment
There was a problem hiding this comment.
Apologies for the late review. Looks like there are a couple of minor merge conflicts. Just conflicts in use items.
joriskleiber
force-pushed
the
replace-duration
branch
2 times, most recently
from
1e63f42 to
25018c0
Compare
joriskleiber
force-pushed
the
replace-duration
branch
from
25018c0 to
563aacd
Compare
bjorn3
approved these changes
Nov 27, 2025
| fn add(self, rhs: Duration) -> Self::Output { | ||
| Duration::new(self.secs + rhs.secs, self.nsecs + rhs.nsecs) | ||
| self.checked_add(rhs) | ||
| .expect("overflow when adding duration") |
Collaborator
There was a problem hiding this comment.
This introduces a panic that is theoretically reachable, but in practice I don't think you can hit it within the lifetime of the universe given that SystemTime uses i64 as seconds field and all durations in the config file are limited to a value much less than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces
system::time::Durationwithstd::time::Duration.I couldn't find any code that still uses negative duration, so I replaced it with it's
stdequivalent.The only place, where I'm not sure if its possible to use an negative duration, is the
prior_validityproperty from theAuthenticationstruct.Should close #1170