Skip to content

Add backchannel_logout attributes #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add backchannel_logout attributes #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,6 +1723,14 @@ saml.encrypt

saml.encryption.certificate

##### `backchannel_logout_session_required`

backchannel.logout.session.required

##### `backchannel_logout_revoke_offline_tokens`

backchannel.logout.revoke.offline.tokens

##### `saml_name_id_format`

saml_name_id_format
Expand Down
4 changes: 4 additions & 0 deletions lib/puppet/provider/keycloak_client/kcadm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ def attributes_properties
:login_theme,
:access_token_lifespan,
:backchannel_logout_url,
:backchannel_logout_session_required,
:backchannel_logout_revoke_offline_tokens,
:saml_name_id_format,
:saml_artifact_binding_url,
:saml_single_logout_service_url_redirect,
Expand All @@ -26,6 +28,8 @@ def dot_attributes_properties
[
:access_token_lifespan,
:backchannel_logout_url,
:backchannel_logout_session_required,
:backchannel_logout_revoke_offline_tokens,
:saml_encrypt,
:saml_assertion_signature,
:saml_signing_certificate,
Expand Down
8 changes: 8 additions & 0 deletions lib/puppet/type/keycloak_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ def insync?(is)
desc 'backchannel.logout.url'
end

newproperty(:backchannel_logout_session_required) do
desc 'backchannel.logout.session.required'
end

newproperty(:backchannel_logout_revoke_offline_tokens) do
desc 'backchannel.logout.revoke.offline.tokens'
end

newproperty(:saml_name_id_format) do
desc 'saml_name_id_format'
end
Expand Down
46 changes: 25 additions & 21 deletions spec/acceptance/5_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,33 @@ class { 'keycloak':
keycloak_realm { 'test': ensure => 'present' }
keycloak_flow { 'foo on test': ensure => 'present' }
keycloak_client { 'test.foo.bar':
realm => 'test',
root_url => 'https://test.foo.bar',
redirect_uris => ['https://test.foo.bar/test1'],
default_client_scopes => ['address'],
secret => 'foobar',
login_theme => 'keycloak',
backchannel_logout_url => 'https://test.foo.bar/logout',
authorization_services_enabled => false,
service_accounts_enabled => true,
browser_flow => 'foo',
roles => ['bar_role', 'other_bar_role'],
realm => 'test',
root_url => 'https://test.foo.bar',
redirect_uris => ['https://test.foo.bar/test1'],
default_client_scopes => ['address'],
secret => 'foobar',
login_theme => 'keycloak',
backchannel_logout_url => 'https://test.foo.bar/logout',
backchannel_logout_session_required => 'true',
backchannel_logout_revoke_offline_tokens => 'true',
Copy link
Owner

@treydock treydock Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these new parameters, can you verify they are actually getting set? Further down is where the expected values are confirmed to be set.

authorization_services_enabled => false,
service_accounts_enabled => true,
browser_flow => 'foo',
roles => ['bar_role', 'other_bar_role'],
}
keycloak_client { 'test.foo.baz':
realm => 'test',
root_url => 'https://test.foo.bar',
redirect_uris => ['https://test.foo.bar/test1'],
default_client_scopes => ['address'],
secret => 'foobar',
login_theme => 'keycloak',
backchannel_logout_url => 'https://test.foo.baz/logout',
authorization_services_enabled => false,
service_accounts_enabled => true,
browser_flow => 'foo',
realm => 'test',
root_url => 'https://test.foo.bar',
redirect_uris => ['https://test.foo.bar/test1'],
default_client_scopes => ['address'],
secret => 'foobar',
login_theme => 'keycloak',
backchannel_logout_url => 'https://test.foo.baz/logout',
backchannel_logout_session_required => 'false',
Copy link
Owner

@treydock treydock Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these new parameters, can you verify they are actually getting set? Further down is where the expected values are confirmed to be set.

backchannel_logout_revoke_offline_tokens => 'false',
authorization_services_enabled => false,
service_accounts_enabled => true,
browser_flow => 'foo',
}
keycloak_client { 'saml.foo.bar':
realm => 'test',
Expand Down
2 changes: 2 additions & 0 deletions spec/unit/puppet/type/keycloak_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@
:secret,
:login_theme,
:backchannel_logout_url,
:backchannel_logout_session_required,
:backchannel_logout_revoke_offline_tokens,
:root_url,
:admin_url,
:base_url,
Expand Down
Loading