Skip to content

Conversation

@nijamaDev
Copy link

Made a simple change so the icons in the social links use react-icons instead of having the pure svg defined in the file, also changed the icons import in the footer to have cleaner and more consistent code.

List of changes:

  • Replaced '@react-icons/all-files' with updated 'react-icons'
  • Cleaner imports for icons
  • Use react-icons components instead of pure svg for the social links
  • Added Discord to the social links and footer
  • Better comments in site.config.ts

@vercel
Copy link

vercel bot commented Dec 19, 2022

@nijamaDev is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

@nijamaDev nijamaDev changed the title react-icons for Social links and footer and Discord Added Discord Added and react-icons for Social links and footer Dec 19, 2022
@nijamaDev nijamaDev changed the title Discord Added and react-icons for Social links and footer Enhancement: Discord Added for Social links and footer and use react-icons instead Dec 27, 2022
@GitMac32
Copy link

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks
Intentionally setting a security policy restricting script sources
checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

@nijamaDev
Copy link
Author

this code is full of garbage bloat & security concerns.

Restricting EsLint from proper checks Intentionally setting a security policy restricting script sources checking for runtime env in gitactions...

I could go on here, but I don't have to.

transitive -bullshit is right. shame on you all

Excuse me? What are you talking about?

I think you might be in the wrong PR. I just added a way of setting up discord to the social links and on the footer and updated the react icons

@socket-security
Copy link

socket-security bot commented Jul 14, 2023

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@transitive-bullshit
Copy link
Owner

Thanks @nijamaDev. This PR looks great. Sorry I don't have time to maintain this project properly and I really have no idea what the other user was talking about.

I'm going through and doing a bunch of updates at the moment, so will consider these changes in a bit.

@socket-security
Copy link

socket-security bot commented Aug 5, 2024

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedreact-tweet-embed@​2.0.0791007577100
Addeddate-fns@​2.30.0991009478100
Added@​vercel/​og@​0.0.19100100999070
Addedreact-icons@​4.12.01001001008580

View full report

@nijamaDev nijamaDev force-pushed the main branch 2 times, most recently from 4c4a505 to 738cc5e Compare November 12, 2024 21:28
nijamaDev and others added 2 commits October 30, 2025 23:09
- replaced @react-icons/all files with react-icons
- use react  icons instead of pure svg for the social links
- Added Discord to the social links and footer

correct imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants