Skip to content

Improved it descriptions for 24 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved it descriptions for 24 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/05-function-overloads/24-function-overloads-vs-union-types.problem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function runGenerator(generator: unknown) {
return generator.run();
}

it("Should accept an object where the generator is a function", () => {
it("Should accept an object with a function run", () => {
const result = runGenerator({
run: () => "hello",
});
Expand All @@ -18,7 +18,7 @@ it("Should accept an object where the generator is a function", () => {
type test1 = Expect<Equal<typeof result, string>>;
});

it("Should accept an object where the generator is a function", () => {
it("Should accept an argument where the generator is a function", () => {
const result = runGenerator(() => "hello");

expect(result).toBe("hello");
Expand Down
4 changes: 2 additions & 2 deletions src/05-function-overloads/24-function-overloads-vs-union-types.solution.1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function runGenerator(generator: { run: () => string } | (() => string)) {
return generator.run();
}

it("Should accept an object where the generator is a function", () => {
it("Should accept an object with a function run", () => {
const result = runGenerator({
run: () => "hello",
});
Expand All @@ -20,7 +20,7 @@ it("Should accept an object where the generator is a function", () => {
type test1 = Expect<Equal<typeof result, string>>;
});

it("Should accept an object where the generator is a function", () => {
it("Should accept an argument where the generator is a function", () => {
const result = runGenerator(() => "hello");

expect(result).toBe("hello");
Expand Down
4 changes: 2 additions & 2 deletions src/05-function-overloads/24-function-overloads-vs-union-types.solution.2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function runGenerator(generator: { run: () => string } | (() => string)) {
return generator.run();
}

it("Should accept an object where the generator is a function", () => {
it("Should accept an object with a function run", () => {
const result = runGenerator({
run: () => "hello",
});
Expand All @@ -18,7 +18,7 @@ it("Should accept an object where the generator is a function", () => {
type test1 = Expect<Equal<typeof result, string>>;
});

it("Should accept an object where the generator is a function", () => {
it("Should accept an argument where the generator is a function", () => {
const result = runGenerator(() => "hello");

expect(result).toBe("hello");
Expand Down