PS-440 #8
Merged
PS-440 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ? new Date(submissionPhase.scheduledEndDate).toUTCString() | ||
| : null | ||
|
|
||
| await helper.postEvent(config.EMAIL_NOTIFICATIN_TOPIC, { |
There was a problem hiding this comment.
[correctness]
The variable submissionEndTime is derived from submissionPhase.scheduledEndDate without validation of the date format. Consider adding a check to ensure scheduledEndDate is a valid date before converting it to a UTC string to prevent potential runtime errors.
| replyTo: config.REGISTRATION_EMAIL.EMAIL_FROM, | ||
| recipients: [email], | ||
| data: { | ||
| handle, |
There was a problem hiding this comment.
[correctness]
The submissionEndTime variable is used directly in the email data payload. Ensure that submissionEndTime is not null before sending the email, or handle the null case appropriately to avoid sending incomplete data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for "Topgear Submission" phase in addition to "Submission" phase when calculating end date.