Skip to content

Replaced handle with memberId for challenge createdBy comparison #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2025
Merged

Replaced handle with memberId for challenge createdBy comparison #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a84951a
Replaced handle with memberId for challenge createdBy comparison
rishabhtc Oct 16, 2025
c699a78
prevent submitter and restricted roles from being combined
rishabhtc Oct 29, 2025
1a332b8
Removed DB call to get existingRole for error message
rishabhtc Oct 29, 2025
fb67833
Added constant for restricted roles
rishabhtc Oct 29, 2025
8fc15a5
Cached restrictedRoleIds locally
rishabhtc Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/ResourceService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ async function init (currentUser, challengeId, resource, isCreated) {
`User ${handle} is not allowed to register.`
)
}
if (!_.get(challenge, 'task.isTask', false) && (_.toLower(challenge.createdBy) === _.toLower(handle) ||
if (!_.get(challenge, 'task.isTask', false) && (_.toLower(challenge.createdBy) === _.toLower(memberId) ||
_.some(userResources, r => r.roleId === config.REVIEWER_RESOURCE_ROLE_ID || r.roleId === config.ITERATIVE_REVIEWER_RESOURCE_ROLE_ID))) {
throw new errors.BadRequestError(
`User ${handle} is not allowed to register.`
Expand Down