Optimization for better speed to fix issue noted by Topgear #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| FROM challenges."Challenge" c | ||
| JOIN bill b | ||
| ON b.challenge_id = c.id | ||
| JOIN LATERAL ( |
There was a problem hiding this comment.
[performance]
The use of JOIN LATERAL with ON TRUE is correct here, but ensure that the performance impact is acceptable. LATERAL joins can be more expensive than regular joins, especially if the subquery is complex or returns a large number of rows. Consider testing the query performance if this section is a bottleneck.
| AND cb."billingAccountId" = '80000062' | ||
| ) ba ON TRUE | ||
| WHERE c."createdAt" >= now() - interval '4 months' | ||
| AND ba.billing_account_id IS NOT NULL |
There was a problem hiding this comment.
[💡 maintainability]
The condition AND ba.billing_account_id IS NOT NULL is redundant since the subquery already filters for billingAccountId = '80000062'. This condition can be removed to simplify the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.