[Work in progress] feat: added ai workflow list component to create or update default reviewer #1298
+84
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const options = workflows.map((wf: { id: string; name: string }) => ({ label: wf.name, value: wf.id })) | ||
| setAiWorkflows(options) | ||
| }) | ||
| }, []) |
There was a problem hiding this comment.
[correctness]
Consider adding error handling for the getAiWorkflows promise to manage potential failures, such as network issues or server errors. This will improve the robustness of the component.
| /> | ||
| </div> | ||
| <div className={styles.inputField}> | ||
| {!isMemberReview && ( |
There was a problem hiding this comment.
[correctness]
Ensure that the aiWorkflowId field is correctly reset when defaultReviewerInfo changes, especially if isMemberReview is toggled. This prevents stale data from being displayed or submitted.
| } | ||
|
|
||
| export async function getAiWorkflows(): Promise<AiWorkflow[]> { | ||
| const response = await xhrGetAsync<AiWorkflow[]>(`${EnvironmentConfig.API.V6}/workflows`) |
There was a problem hiding this comment.
[❗❗ correctness]
Consider adding error handling for the xhrGetAsync call to manage potential network or server errors gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-2540
What's in this PR?