Update more deprecated lodash methods

Author: Nick Litwin

app/profile/subtrack/subtrack.controller.js

@@ -85,7 +85,7 @@ import _ from 'lodash'
           var mustHaveMetrics = ['rank', 'rating', 'reliability']
           // check if rating, rank & reliability are all set
           var _filteredObjs = _.filter(vm.subTrackStats, function(k) { return _.indexOf(mustHaveMetrics, k.label) > -1})
-          if (_.all(_.map(_filteredObjs, 'val'), function(v) { return !v})) {
+          if (_.every(_.map(_filteredObjs, 'val'), function(v) { return !v})) {
             // all false filter em out
             _.remove(vm.subTrackStats, function(k) { return _.indexOf(mustHaveMetrics, k.label) > -1})
           }

app/services/externalAccounts.service.spec.js

@@ -91,7 +91,7 @@ describe('ExternalAccount Service', function() {
     service.getAllExternalLinks('test1', 111, false).then(function(data) {
       expect(data).to.be.defined
       expect(_.map(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
-      expect(_.all(_.map(data, 'data'))).to.be.truthy
+      expect(_.every(_.map(data, 'data'))).to.be.truthy
     })
     $httpBackend.flush()
   })
@@ -116,7 +116,7 @@ describe('ExternalAccount Service', function() {
     service.getAllExternalLinks('test1', 111, true).then(function(data) {
       expect(data).to.be.defined
       expect(_.map(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
-      expect(_.all(_.map(data, 'data'))).to.be.truthy
+      expect(_.every(_.map(data, 'data'))).to.be.truthy
     })
     $httpBackend.flush()
   })

app/services/introduction.service.js

@@ -41,21 +41,21 @@ import _ from 'lodash'
         var handleInParams = $stateParams.userHandle ? $stateParams.userHandle.toLowerCase() : null
         var userIntroJSStats = store.get(userId)
 
-        if (!userIntroJSStats.dashboardIntroComplete && _.contains(currentPage, 'dashboard')) {
+        if (!userIntroJSStats.dashboardIntroComplete && _.includes(currentPage, 'dashboard')) {
           userIntroJSStats.dashboardIntroComplete = true
           store.set(userId, userIntroJSStats)
 
           return getIntroData(currentPage)
         }
 
-        if (!userIntroJSStats.profileAboutIntroComplete && _.contains(currentPage, 'profile.about') && userHandle === handleInParams) {
+        if (!userIntroJSStats.profileAboutIntroComplete && _.includes(currentPage, 'profile.about') && userHandle === handleInParams) {
           userIntroJSStats.profileAboutIntroComplete = true
           store.set(userId, userIntroJSStats)
 
           return getIntroData(currentPage)
         }
 
-        if (!userIntroJSStats.profileSubtrackIntroComplete && _.contains(currentPage, 'profile.subtrack') && userHandle === handleInParams && $stateParams.subTrack.toLowerCase() !== 'copilot') {
+        if (!userIntroJSStats.profileSubtrackIntroComplete && _.includes(currentPage, 'profile.subtrack') && userHandle === handleInParams && $stateParams.subTrack.toLowerCase() !== 'copilot') {
           userIntroJSStats.profileSubtrackIntroComplete = true
           store.set(userId, userIntroJSStats)
 

app/settings/edit-profile/edit-profile.controller.js

@@ -155,9 +155,9 @@ import _ from 'lodash'
 
     function processData(userInfo) {
       vm.tracks = {
-        DESIGN: _.contains(userInfo.tracks, 'DESIGN'),
-        DEVELOP: _.contains(userInfo.tracks, 'DEVELOP'),
-        DATA_SCIENCE: _.contains(userInfo.tracks, 'DATA_SCIENCE')
+        DESIGN: _.includes(userInfo.tracks, 'DESIGN'),
+        DEVELOP: _.includes(userInfo.tracks, 'DEVELOP'),
+        DATA_SCIENCE: _.includes(userInfo.tracks, 'DATA_SCIENCE')
       }
     }