Update to remove deprecated lodash methods

Author: Nick Litwin

app/directives/external-account/external-account.spec.js

@@ -121,7 +121,7 @@ describe('External Accounts Directive', function() {
       scope.linkedAccounts = null
       scope.$digest()
       expect(element.isolateScope().accountList).to.have.length(7)
-      expect(_.all(_.pluck(element.isolateScope().accountList, 'status'))).to.be.false
+      expect(_.every(_.map(element.isolateScope().accountList, 'status'))).to.be.false
     })
 
     it('should link external account ', function() {

app/directives/page-state-header/page-state-header.directive.js

@@ -95,7 +95,7 @@ import _ from 'lodash'
     function displayMoneyEarned(handle) {
       ProfileService.getUserFinancials(handle)
       .then(function(financials) {
-        vm.moneyEarned = _.sum(_.pluck(financials, 'amount'))
+        vm.moneyEarned = _.sum(_.map(financials, 'amount'))
 
         if (!vm.moneyEarned) {
           $scope.hideMoney = true

app/my-challenges/my-challenges.controller.js

@@ -81,7 +81,7 @@ import _ from 'lodash'
       .then(function(data) {
         // data should be an array of 2 objects each with it's own array (2D array with metadata)
 
-        vm.totalCount = _.sum(_.pluck(data, 'metadata.totalCount'))
+        vm.totalCount = _.sum(_.map(data, 'metadata.totalCount'))
         vm.myChallenges = vm.myChallenges.concat(_.union(data[0], data[1]))
         if (vm.totalCount === 0) {
           _checkForParticipation().then(function() {

app/profile/subtrack/subtrack.controller.js

@@ -85,7 +85,7 @@ import _ from 'lodash'
           var mustHaveMetrics = ['rank', 'rating', 'reliability']
           // check if rating, rank & reliability are all set
           var _filteredObjs = _.filter(vm.subTrackStats, function(k) { return _.indexOf(mustHaveMetrics, k.label) > -1})
-          if (_.all(_.pluck(_filteredObjs, 'val'), function(v) { return !v})) {
+          if (_.all(_.map(_filteredObjs, 'val'), function(v) { return !v})) {
             // all false filter em out
             _.remove(vm.subTrackStats, function(k) { return _.indexOf(mustHaveMetrics, k.label) > -1})
           }

app/services/externalAccounts.service.spec.js

@@ -12,7 +12,6 @@ describe('ExternalAccount Service', function() {
   var auth0, userService
   var profileGet, profilePost, profileDelete
 
-
   beforeEach(function() {
     bard.appModule('topcoder')
     bard.inject(this, 'ExternalAccountService', '$httpBackend', '$q', 'CONSTANTS', 'JwtInterceptorService', 'auth', 'UserService')
@@ -91,8 +90,8 @@ describe('ExternalAccount Service', function() {
     // spy
     service.getAllExternalLinks('test1', 111, false).then(function(data) {
       expect(data).to.be.defined
-      expect(_.pluck(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
-      expect(_.all(_.pluck(data, 'data'))).to.be.truthy
+      expect(_.map(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
+      expect(_.all(_.map(data, 'data'))).to.be.truthy
     })
     $httpBackend.flush()
   })
@@ -101,7 +100,7 @@ describe('ExternalAccount Service', function() {
     // spy
     service.getAllExternalLinks('test1', 111, true).then(function(data) {
       expect(data).to.be.defined
-      expect(_.pluck(data, 'provider')).to.include.members(['dribbble', 'github', 'behance', 'bitbucket','stackoverflow'])
+      expect(_.map(data, 'provider')).to.include.members(['dribbble', 'github', 'behance', 'bitbucket','stackoverflow'])
       expect(data).to.have.length(5)
       var nullAccounts = _.remove(data, function(n) {return n.data.status === 'PENDING'})
       expect(nullAccounts).to.have.length(1)
@@ -116,8 +115,8 @@ describe('ExternalAccount Service', function() {
     // spy
     service.getAllExternalLinks('test1', 111, true).then(function(data) {
       expect(data).to.be.defined
-      expect(_.pluck(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
-      expect(_.all(_.pluck(data, 'data'))).to.be.truthy
+      expect(_.map(data, 'provider')).to.include.members(['dribbble', 'github','bitbucket', 'stackoverflow'])
+      expect(_.all(_.map(data, 'data'))).to.be.truthy
     })
     $httpBackend.flush()
   })

app/services/externalLinks.service.js

@@ -34,12 +34,12 @@ import _ from 'lodash'
             })
           }
           // add provider type as weblink
-          links = _(links).forEach(function(l) {
-            l.provider = 'weblink'
-            if (l.synchronizedAt === 0) {
-              l.status = 'PENDING'
+          links.forEach(function(l, i, array) {
+            array[i].provider = 'weblink'
+            if (array[i].synchronizedAt === 0) {
+              array[i].status = 'PENDING'
             }
-          }).value()
+          })
           return links
         })
     }

app/services/userStats.service.spec.js

@@ -29,30 +29,30 @@ describe('User Stats Service', function() {
       var _data = UserStatsService.getIterableStats('DEVELOP', 'ASSEMBLY_COMPETITION', stats)
       expect(_data).to.have.length(6)
 
-      expect(_.pluck(_data, 'val')).to.have.members(['1,733', '25', '95%', '16', '10', '80%'])
-      expect(_.pluck(_data, 'label')).to.have.members(['rating', 'rank', 'percentile', 'challenges', 'wins', 'reliability'])
+      expect(_.map(_data, 'val')).to.have.members(['1,733', '25', '95%', '16', '10', '80%'])
+      expect(_.map(_data, 'label')).to.have.members(['rating', 'rank', 'percentile', 'challenges', 'wins', 'reliability'])
     })
 
     it('should return stats for design-webdesign ', function() {
       var _data = UserStatsService.getIterableStats('DESIGN', 'WEB_DESIGNS', stats)
       expect(_data).to.have.length(2)
-      expect(_.pluck(_data, 'val')).to.have.members(['190','418'])
-      expect(_.pluck(_data, 'label')).to.have.members(['wins', 'challenges'])
+      expect(_.map(_data, 'val')).to.have.members(['190','418'])
+      expect(_.map(_data, 'label')).to.have.members(['wins', 'challenges'])
     })
 
     it('should return stats for data-science: srms ', function() {
       var _data = UserStatsService.getIterableStats('DATA_SCIENCE', 'SRM', stats)
       expect(_data).to.have.length(5)
-      expect(_.pluck(_data, 'label')).to.have.members(['rating', 'rank', 'percentile', 'competitions', 'volatility'])
-      expect(_.pluck(_data, 'val')).to.have.members(['799', '6,280', '26%', '10', '473'])
+      expect(_.map(_data, 'label')).to.have.members(['rating', 'rank', 'percentile', 'competitions', 'volatility'])
+      expect(_.map(_data, 'val')).to.have.members(['799', '6,280', '26%', '10', '473'])
     })
 
 
     it('should return stats for Copilot ', function() {
       var _data = UserStatsService.getIterableStats('COPILOT', 'COPILOT', stats)
       expect(_data).to.have.length(5)
-      expect(_.pluck(_data, 'label')).to.have.members(['active challenges', 'active projects', 'total challenges', 'total projects', 'fulfillment'])
-      expect(_.pluck(_data, 'val')).to.have.members([0, '1', '24', '3', '84%'])
+      expect(_.map(_data, 'label')).to.have.members(['active challenges', 'active projects', 'total challenges', 'total projects', 'fulfillment'])
+      expect(_.map(_data, 'val')).to.have.members([0, '1', '24', '3', '84%'])
     })
   })
 
@@ -322,7 +322,7 @@ describe('User Stats Service', function() {
       }]
       var filtered = UserStatsService.filterStats(toTest)
       expect(filtered).to.exist.to.have.length(3)
-      expect(_.pluck(filtered, 'showStats')).to.have.members([true, true, true])
+      expect(_.map(filtered, 'showStats')).to.have.members([true, true, true])
     })
   })
 

app/skill-picker/skill-picker.controller.js

@@ -56,7 +56,7 @@ import _ from 'lodash'
      * Verfies if the communities section state has been modified by the user in any way.
      */
     function isCommunitiesDirty() {
-      var community = _.findWhere(vm.communities, {dirty: true})
+      var community = _.find(vm.communities, {dirty: true})
       return !!community
     }
 
@@ -97,7 +97,7 @@ import _ from 'lodash'
         vm.loadingCommunities = false
         responses.forEach(function(program) {
           if (program) {
-            var community = _.findWhere(vm.communities, {programId: program.eventId})
+            var community = _.find(vm.communities, {programId: program.eventId})
             if (community) {
               // set display false to avoid showing already enabled/registered program
               // we expect display property to be modified after first load  of the page
@@ -111,7 +111,7 @@ import _ from 'lodash'
           }
         })
         // if there exists at least 1 community which can be displayed, set showCommunity flag to true
-        var community = _.findWhere(vm.communities, {display: true})
+        var community = _.find(vm.communities, {display: true})
         if (community) {
           vm.showCommunity = true
         }