Make TraitRenamedCaseOnly extend Delta

Author: emmetog

src/PHPSemVerChecker/Analyzer/TraitAnalyzer.php

@@ -58,19 +58,25 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
 
 		foreach ($toVerify as $key) {
 			$fileBefore = $filesBeforeKeyed[$key];
-			/** @var \PhpParser\Node\Stmt\Class_ $traitBefore */
 			$traitBefore = $traitsBeforeKeyed[$key];
 			$fileAfter = $filesAfterKeyed[$key];
-			/** @var \PhpParser\Node\Stmt\Class_ $traitBefore */
 			$traitAfter = $traitsAfterKeyed[$key];
 
 			// Leave non-strict comparison here
 			if ($traitBefore != $traitAfter) {
 
 				// Check for name case change.
 				// If we entered this section then the normalized names (lowercase) were equal.
-				if($traitBefore->name !== $traitAfter->name) {
-					$report->add($this->context, new TraitRenamedCaseOnly($fileAfter, $traitAfter));
+				if ($traitBefore->name !== $traitAfter->name) {
+					$report->add(
+						$this->context,
+						new TraitRenamedCaseOnly(
+							$fileBefore,
+							$traitBefore,
+							$fileAfter,
+							$traitAfter
+						)
+					);
 				}
 
 				$analyzers = [

src/PHPSemVerChecker/Operation/TraitOperationDelta.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace PHPSemVerChecker\Operation;
+
+use PhpParser\Node\Stmt\Trait_;
+use PHPSemVerChecker\Node\Statement\Trait_ as PTrait;
+
+class TraitOperationDelta extends Operation
+{
+	/**
+	 * @var string
+	 */
+	protected $fileBefore;
+	/**
+	 * @var \PhpParser\Node\Stmt\Trait_
+	 */
+	protected $traitBefore;
+	/**
+	 * @var string
+	 */
+	protected $fileAfter;
+	/**
+	 * @var \PhpParser\Node\Stmt\Trait_
+	 */
+	protected $traitAfter;
+
+	public function __construct($fileBefore, Trait_ $traitBefore, $fileAfter, Trait_ $traitAfter)
+	{
+		$this->fileBefore = $fileBefore;
+		$this->traitBefore = $traitBefore;
+		$this->fileAfter = $fileAfter;
+		$this->traitAfter = $traitAfter;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getLocation()
+	{
+		return $this->fileAfter;
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getLine()
+	{
+		return $this->traitAfter->getLine();
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getTarget()
+	{
+		return PTrait::getFullyQualifiedName($this->traitAfter);
+	}
+}

src/PHPSemVerChecker/Operation/TraitRenamedCaseOnly.php

@@ -5,7 +5,7 @@
 use PhpParser\Node\Stmt\Trait_;
 use PHPSemVerChecker\Node\Statement\Trait_ as PTrait;
 
-class TraitRenamedCaseOnly extends Operation {
+class TraitRenamedCaseOnly extends TraitOperationDelta {
 	/**
 	 * @var string
 	 */
@@ -14,46 +14,4 @@ class TraitRenamedCaseOnly extends Operation {
 	 * @var string
 	 */
 	protected $reason = 'Trait was renamed (case only).';
-	/**
-	 * @var string
-	 */
-	protected $fileAfter;
-	/**
-	 * @var \PhpParser\Node\Stmt\Trait_
-	 */
-	protected $traitAfter;
-
-	/**
-	 * @param string                      $fileAfter
-	 * @param \PhpParser\Node\Stmt\Trait_ $traitAfter
-	 */
-	public function __construct($fileAfter, Trait_ $traitAfter)
-	{
-		$this->fileAfter = $fileAfter;
-		$this->traitAfter = $traitAfter;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileAfter;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->traitAfter->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PTrait::getFullyQualifiedName($this->traitAfter);
-	}
 }