Make ClassMethodRenamedCaseOnly extend Delta

Author: emmetog

src/PHPSemVerChecker/Analyzer/ClassAnalyzer.php

@@ -67,12 +67,18 @@ public function analyze(Registry $registryBefore, Registry $registryAfter)
 			// Leave non-strict comparison here
 			if ($classBefore != $classAfter) {
 
-				// Check for case change of class name
-				if(
-					$classBefore->name !== $classAfter->name
-					&& strtolower($classBefore->name) === strtolower($classAfter->name)
-				) {
-					$report->add($this->context, new ClassRenamedCaseOnly($fileAfter, $classAfter));
+				// Check for case change of class name.
+				// If we entered this section then the normalized names (lowercase) were equal.
+				if ($classBefore->name !== $classAfter->name) {
+					$report->add(
+						$this->context,
+						new ClassRenamedCaseOnly(
+							$fileBefore,
+							$classBefore,
+							$fileAfter,
+							$classAfter
+						)
+					);
 				}
 
 				$analyzers = [

src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php

@@ -94,8 +94,19 @@ public function analyze(Stmt $contextBefore, Stmt $contextAfter)
 
 				// Detect method renamed case only.
 				// If we entered this section then the normalized names (lowercase) were equal.
-				if($methodBefore->name !== $methodAfter->name) {
-					$report->add($this->context, new ClassMethodRenamedCaseOnly($this->context, $this->fileAfter, $contextAfter, $methodAfter));
+				if ($methodBefore->name !== $methodAfter->name) {
+					$report->add(
+						$this->context,
+						new ClassMethodRenamedCaseOnly(
+							$this->context,
+							$this->fileBefore,
+							$contextAfter,
+							$methodBefore,
+							$this->fileAfter,
+							$contextAfter,
+							$methodAfter
+						)
+					);
 				}
 
 				$signatureResult = Signature::analyze($methodBefore->getParams(), $methodAfter->getParams());

src/PHPSemVerChecker/Operation/ClassMethodRenamedCaseOnly.php

@@ -2,7 +2,7 @@
 
 namespace PHPSemVerChecker\Operation;
 
-class ClassMethodRenamedCaseOnly extends ClassMethodOperationUnary
+class ClassMethodRenamedCaseOnly extends ClassMethodOperationDelta
 {
 	/**
 	 * @var array

src/PHPSemVerChecker/Operation/ClassOperationDelta.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace PHPSemVerChecker\Operation;
+
+use PhpParser\Node\Stmt\Class_;
+use PHPSemVerChecker\Node\Statement\Class_ as PClass;
+
+class ClassOperationDelta extends Operation
+{
+	/**
+	 * @var string
+	 */
+	protected $fileBefore;
+	/**
+	 * @var \PhpParser\Node\Stmt\Class_
+	 */
+	protected $classBefore;
+	/**
+	 * @var string
+	 */
+	protected $fileAfter;
+	/**
+	 * @var \PhpParser\Node\Stmt\Class_
+	 */
+	protected $classAfter;
+
+	/**
+	 * @param string                      $file
+	 * @param \PhpParser\Node\Stmt\Class_ $class
+	 */
+	public function __construct($fileBefore, Class_ $classBefore, $fileAfter, Class_ $classAfter)
+	{
+		$this->fileBefore = $fileBefore;
+		$this->classBefore = $classBefore;
+		$this->fileAfter = $fileAfter;
+		$this->classAfter = $classAfter;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getLocation()
+	{
+		return $this->fileAfter;
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getLine()
+	{
+		return $this->classAfter->getLine();
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getTarget()
+	{
+		return PClass::getFullyQualifiedName($this->classAfter);
+	}
+}

src/PHPSemVerChecker/Operation/ClassRenamedCaseOnly.php

@@ -5,7 +5,7 @@
 use PhpParser\Node\Stmt\Class_;
 use PHPSemVerChecker\Node\Statement\Class_ as PClass;
 
-class ClassRenamedCaseOnly extends Operation {
+class ClassRenamedCaseOnly extends ClassOperationDelta {
 	/**
 	 * @var string
 	 */
@@ -22,38 +22,4 @@ class ClassRenamedCaseOnly extends Operation {
 	 * @var \PhpParser\Node\Stmt\Class_
 	 */
 	protected $classAfter;
-
-	/**
-	 * @param string                      $fileAfter
-	 * @param \PhpParser\Node\Stmt\Class_ $classAfter
-	 */
-	public function __construct($fileAfter, Class_ $classAfter)
-	{
-		$this->fileAfter = $fileAfter;
-		$this->classAfter = $classAfter;
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getLocation()
-	{
-		return $this->fileAfter;
-	}
-
-	/**
-	 * @return int
-	 */
-	public function getLine()
-	{
-		return $this->classAfter->getLine();
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getTarget()
-	{
-		return PClass::getFullyQualifiedName($this->classAfter);
-	}
 }