Add bitflags! with CompletionFlags for better UX. #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugarraysam
force-pushed
the
bitflags-cqe-flags
branch
from
7e37ca5 to
f4ca4ca
Compare
sugarraysam
commented
Oct 20, 2025
| pub fn flags(&self) -> CompletionFlags { | ||
| // Use retain as the upper 16 bits store buffer ID if BUFFER_SELECT opt | ||
| // is enabled. | ||
| CompletionFlags::from_bits_retain(self.0.flags) |
Contributor
Author
There was a problem hiding this comment.
I initially missed the fact that upper 16 bits have the buffer ID.
We use from_bits_retain to ensure we dont lose that information.
Member
|
This looks good. I'll hold it until next version to merge. |
sugarraysam
force-pushed
the
bitflags-cqe-flags
branch
from
f4ca4ca to
b01e8d7
Compare
Contributor
Author
|
Rebased on 0.7.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
The only concern is this is most likely a breaking change for users of the library. If added through safe release mechanism the impact should be minimal?
More maintainable and better UX than passing u32's around.