-
Notifications
You must be signed in to change notification settings - Fork 1k
Feat(exasol): qualify bare stars to facilitate transpilation #6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(exasol): qualify bare stars to facilitate transpilation #6431
Conversation
…and add alias in exasol
|
@nnamdi16 it seems like this PR does not handle I think we would need to add |
Its a very good idea @georgesittas. I would look into it |
|
Hey @nnamdi16, any plans to take this to the finish line? |
Yes @georgesittas I would fix the concerns. |
…lect_expressions, mutating the original star and fixing normalization issues
What motivated this PR?
Exasol doesn't support a bare * alongside other select items.
How is the existing logic in main incorrect?
For example, when transpiling
SELECT *, 1 FROM TESTto Exasol, the query returned (SELECT *, 1 FROM TEST) would fail because Exasol requires that the bare * is scoped with an alias.How does the PR address the aforementioned issues?
The PR preprocesses SELECT by transforming unscoped star to .* and attaching TableAlias.
Fix:
SELECT *, 1 FROM TEST->SELECT T.*, 1 FROM TEST AS TProvide documentation for the SQL functions involved in the implementation & explain whether semantics change / are preserved
The issue is not specifically stated in the documentation, but I can provide a screenshot if required