Skip to content

fix perl version checks to use numeric comparisons #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix perl version checks to use numeric comparisons #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Exporter/Tiny.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ our $VERSION = '1.006002';
our @EXPORT_OK = qw< mkopt mkopt_hash _croak _carp >;

BEGIN {
*_HAS_NATIVE_LEXICAL_SUB = ( $] ge '5.037002' )
*_HAS_NATIVE_LEXICAL_SUB = ( "$]" >= 5.037002 )
? sub () { !!1 }
: sub () { !!0 };
*_HAS_MODULE_LEXICAL_SUB = ( $] ge '5.011002' and eval('require Lexical::Sub') )
*_HAS_MODULE_LEXICAL_SUB = ( "$]" >= 5.011002 and eval('require Lexical::Sub') )
? sub () { !!1 }
: sub () { !!0 };
};
Expand Down Expand Up @@ -134,7 +134,7 @@ sub unimport
sub _exporter_lexical_installer {
_HAS_NATIVE_LEXICAL_SUB and return sub {
my ( $sigilname, $sym ) = @{ $_[1] };
no warnings ( $] ge '5.037002' ? 'experimental::builtin' : () );
no warnings ( "$]" >= 5.037002 ? 'experimental::builtin' : () );
builtin::export_lexically( $sigilname, $sym );
};
_HAS_MODULE_LEXICAL_SUB and return sub {
Expand Down
4 changes: 2 additions & 2 deletions meta/DYNAMIC_CONFIG.PL
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
$prereq_type = 'requires';
}

if ( $] ge 5.011002 and $] lt 5.037002 ) {
if ( "$]" >= 5.011002 and "$]" < 5.037002 ) {
$meta->{prereqs}{runtime}{$prereq_type}{'Lexical::Var'} = '0.010';
}

# idk, this should be automatic or summint? put it in explicitly.
$meta->{prereqs}{runtime}{requires}{'Test::More'} = '0.47'
if $] lt 5.006002;
if "$]" < 5.006002;