PULL_REQUEST_TEMPLATE.md: use more robust links #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relative links may not work if the PR is created from a branch containing slashes in it.
owenvoke
approved these changes
Nov 15, 2018
Member
owenvoke
left a comment
owenvoke
left a comment
There was a problem hiding this comment.
This looks great! Thanks @waldyrious
agnivade
approved these changes
Nov 15, 2018
sbrl
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative links may not work if the PR is created from a branch containing slashes in it, as pointed out by @pxgamer in this comment.
ps - I've tested the changes in this PR by manually changing the links in the checklist above. It works as expected :)