Skip to content

Conversation

@ethankonk
Copy link
Contributor

Summary & Motivation

  • Generated docs have been broken in the sdk for a while now, one because of a type change in react-wallet-kit and two because of an incorrectly configured typedoc.json file.
  • Updated both to make sure make sync-gen-docs works again!

How I Tested These Changes

  • locally

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 1, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5827f7d:

Sandbox Source
@turnkey/example-react-components Configuration

},
"outputs": [
{
// requires typedoc-plugin-markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to remove this comment or else its not valid JSON.

@ethankonk ethankonk force-pushed the ethan/changelog-fix branch from fa8eb74 to 37ca90e Compare December 2, 2025 22:39
Copy link

@fainashalts fainashalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ethankonk ethankonk force-pushed the ethan/changelog-fix branch from 37ca90e to 5827f7d Compare December 5, 2025 15:13
@ethankonk ethankonk merged commit 47c5391 into main Dec 5, 2025
8 checks passed
@ethankonk ethankonk deleted the ethan/changelog-fix branch December 5, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants