Skip to content

[ENH] remove the max_iter parameter #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ENH] remove the max_iter parameter #396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9c462
remove the max_iter parameter
TonyBagnall Sep 4, 2025
a1b4889
Merge branch 'main' into ajb/max_iter
MatthewMiddlehurst Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tsml_eval/experiments/_get_clusterer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ def _set_clusterer_distance_based(
"method": "subgradient",
}
return TimeSeriesKMeans(
max_iter=50,
n_init=10,
init=init_algorithm,
distance=distance,
Expand All @@ -331,7 +330,6 @@ def _set_clusterer_distance_based(
)
elif "ba" in c:
return TimeSeriesKMeans(
max_iter=50,
n_init=10,
init=init_algorithm,
distance=distance,
Expand All @@ -343,7 +341,6 @@ def _set_clusterer_distance_based(
)
else:
return TimeSeriesKMeans(
max_iter=50,
n_init=10,
init=init_algorithm,
distance=distance,
Expand All @@ -354,7 +351,6 @@ def _set_clusterer_distance_based(
)
elif "kmedoids" in c or "timeserieskmedoids" in c:
return TimeSeriesKMedoids(
max_iter=50,
n_init=10,
init=init_algorithm,
distance=distance,
Expand All @@ -365,7 +361,6 @@ def _set_clusterer_distance_based(
)
elif "pam" in c or "timeseriespam" in c:
return TimeSeriesKMedoids(
max_iter=50,
n_init=10,
init=init_algorithm,
distance=distance,
Expand All @@ -385,7 +380,6 @@ def _set_clusterer_distance_based(
)
elif "clara" in c or "timeseriesclara" in c:
return TimeSeriesCLARA(
max_iter=50,
init=init_algorithm,
distance=distance,
distance_params=distance_params,
Expand All @@ -410,7 +404,6 @@ def _set_clusterer_distance_based(
return KSpectralCentroid(
# Max shift set to n_timepoints when max_shift is None
max_shift=None,
max_iter=50,
init=init_algorithm,
tol=1e-06,
random_state=random_state,
Expand All @@ -419,15 +412,13 @@ def _set_clusterer_distance_based(
elif "kshape" in c:
return TimeSeriesKShape(
init=init_algorithm,
max_iter=50,
n_init=10,
tol=1e-06,
random_state=random_state,
**kwargs,
)
elif "timeserieskernelkmeans" in c:
return TimeSeriesKernelKMeans(
max_iter=50,
n_init=10,
tol=1e-06,
random_state=random_state,
Expand Down