Fix data masking in uncount() #1619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to issue #1583.
If
.remove = TRUE,uncount()should remove the weight column from the output. Currently this only happens whenweightis a variable, but not when using.data$var, because the column is set toNULLonly whenquo_is_symbol(weights_quo)is TRUE.The PR adds another condition that looks for a data masking expression, and if found, sets the
weightvariable to NULL. A new test shows thatuncount(df, var)anduncount(df, .data$var)now give the same output.This PR was prepared in collaboration with @gguyver.