-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Advance all deprecations #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advance all deprecations #7762
Conversation
By removing compatibility for this altogether
By removing support for it
By removing the warning about it entirely, it was being ignored anyways
1807491 to
f84976c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably easiest to start with the NEWS to get an overview, then briefly look at any of the standalone commits and see if any jump out at you as warranting extra attention
|
|
||
| ### Breaking changes | ||
|
|
||
| * The following were already deprecated, and are now defunct: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to again remind people what the replacements are (I asked claude to do that for me). I also generally include the version number they were deprecated, and the date it was released.
Deprecationpalooza!
In addition to these, see #7761, #7760, #7758, and #7757, all of which require a bit more individual care.
Revdeps in #7763 show ~150 issues, but 100 of them are due to removal of the already defunct
dplyr::id(). People were usingmutate(df, col = id)and not listingidas aglobalVariable()so now they will get a note about this. I can send all of these people a github issue / email, but I was not planning on doing individual PRs to them. It does seem worth pushing on this though.Plus set to CRAN lifecycle