Skip to content

Conversation

@tobiasehlert
Copy link
Member

This pull request includes a minor change to the src/TibiaCharactersCharacter.go file. The change involves modifying the DeathsTruncated field in the Character struct to be optional in the JSON output.

  • src/TibiaCharactersCharacter.go: Changed the DeathsTruncated field in the Character struct to include the omitempty tag, making it optional in the JSON output.

@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Apr 1, 2025
@tobiasehlert tobiasehlert self-assigned this Apr 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (1aedf92) to head (4cd7517).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          22       22           
  Lines        3694     3694           
=======================================
  Hits         2966     2966           
  Misses        587      587           
  Partials      141      141           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasehlert tobiasehlert requested a review from Copilot April 3, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to omit the "deaths_truncated" field from the JSON output when it is false by adding the "omitempty" tag.

  • Modified the JSON tag for DeathsTruncated in the Character struct
  • Ensures that the field is only included when its value is true

@tobiasehlert tobiasehlert merged commit 87edfbe into main Apr 3, 2025
8 checks passed
@tobiasehlert tobiasehlert deleted the fix-omit-character-deaths_truncated-if-false branch April 3, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

2 participants