Skip to content

Conversation

@tobiasehlert
Copy link
Member

This pull request includes changes to the src/TibiaCharactersCharacter.go and src/TibiaCharactersCharacter_test.go files. The changes enhance the character death handling and add a new test case.

Enhancements to character death handling:

New test case addition:

  • src/TibiaCharactersCharacter_test.go: Added a new test function TestNumber17 to validate the character death data for a specific character, including detailed checks on the death records.

fix #462

@tobiasehlert tobiasehlert added bug Something isn't working go Pull requests that update Go code labels Apr 1, 2025
@tobiasehlert tobiasehlert self-assigned this Apr 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (1aedf92) to head (b2f2d0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          22       22           
  Lines        3694     3694           
=======================================
  Hits         2966     2966           
  Misses        587      587           
  Partials      141      141           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasehlert tobiasehlert merged commit 875cb36 into main Apr 1, 2025
8 checks passed
@tobiasehlert tobiasehlert deleted the fix-character-death-html-header-change branch April 1, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

bug: character deaths not parsed after html changes

2 participants