Skip to content

Conversation

@tobiasehlert
Copy link
Member

This pull request includes several changes to the TibiaCharactersCharacter.go file, focusing on improving the handling of character death data and adding a new test case. Key changes include adding an omitempty tag to the Level field, improving string sanitization, and adding logic to handle deaths with assists more accurately. Additionally, a new test case has been added to validate these changes.

Improvements to character death data handling:

New test case:

fix #203
fix #402
fix #448

@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Mar 3, 2025
@tobiasehlert tobiasehlert self-assigned this Mar 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (9df2bd7) to head (07c1a86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   80.19%   80.30%   +0.10%     
==========================================
  Files          22       22              
  Lines        3666     3686      +20     
==========================================
+ Hits         2940     2960      +20     
  Misses        585      585              
  Partials      141      141              

@tobiasehlert tobiasehlert merged commit 086f483 into main Mar 3, 2025
8 checks passed
@tobiasehlert tobiasehlert deleted the fix-deaths-with-assisted-only branch March 3, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

2 participants