feat: add tibia_urls field into information-section

[Kai-Animator]

This pull request addresses Issue #381 by adding the Link field to the Information section in all API responses. The Link field provides a direct URL to the source data on the official Tibia website.

Changes Overview:

• Updated Information Struct:
  • Added a new Link field to the Information struct in webserver.go:

    type Information struct {
        APIDetails APIDetails `json:"api"`       // The API details.
        Timestamp  string     `json:"timestamp"` // The timestamp from when the data was processed.
        Link       string     `json:"link"`      // The link to the source of the data.
        Status     Status     `json:"status"`    // The response status information.
    }

• Modified API Handlers:

  • Updated all API endpoint handlers to populate the Link field with the appropriate URL pointing to the source data.

  • Example from TibiaWorldsWorld.go:

    return WorldResponse{
        World: World{
            // ... existing fields ...
        },
        Information: Information{
            APIDetails: TibiaDataAPIDetails,
            Timestamp:  TibiaDataDatetime(""),
            Link:       "https://www.tibia.com/community/?subtopic=worlds&world=" + world,
            Status: Status{
                HTTPCode: http.StatusOK,
            },
        },
    }, nil

Testing:

• Tested all modified endpoints to ensure the Link field is correctly populated.
• Verified that the URLs are accurate and lead to the correct pages on Tibia.com.

---

Notes:

• NewsList was kind of tricky to handle the different patterns so I decided to sum all different URLs into only "https://www.tibia.com/news/?subtopic=newsarchive"

• This is my first PR in the project so I am open to feedback and willing to make any necessary changes to meet the project's standards.

fix #381

[tobiasehlert]

Thanks for the PR @Kai-Animator, this is a good start!
There are some things that I'd like to be adjusted.

One of them is that there is already a link for every endpoints source available, so hardcoding the line in the "Link" field is not optimal. It would be better to have it being populated by the value set in "tibiadataRequest.URL" before being sent to tibiaDataRequestHandler.

For instance here:
https://github.com/TibiaData/tibiadata-api-go/blob/a4afbe1bf78013effcdf6e71605d31811374531b/src/webserver.go#L394-L407

I'd also like the "Link" to be named "TibiaURL" instead, since that's a slightly better description of that it is.
Also, we should probably want to have a []string as well, in case we add multi-upstream sources.

[Kai-Animator]

Thanks for the review @tobiasehlert . I will work on it 👍

[Kai-Animator]

Hi @tobiasehlert 👋

I’ve implemented the changes you requested:

• The "Link" field is now populated using the value from tibiadataRequest.URL before it's sent to tibiaDataRequestHandler, rather than hardcoding the URL. (Newslist and HousesOverview might need refactor)
• Renamed "Link" to "TibiaURL".
• I've also updated the field to support a []string for multi-upstream sources in the future (HousesOverview is using multiple URLs now).

Please let me know if there’s anything else :]

[phenpessoa]

Since this is now slice, I think it should probably be named TibiaURLs, plural.

[tobiasehlert]

Yeah good input @phenpessoa. 👍

[phenpessoa]

The field name was updated but the json is still called tibia_url. I think it should probably be tibia_urls.

[Kai-Animator]

The field name was updated but the json is still called tibia_url. I think it should probably be tibia_urls.

Hey @phenpessoa, thanks for looking at the code, is this the change that you mentioned?

[phenpessoa]

Yup! Looks good.

[tobiasehlert]

We are getting closer! 🚀
The news endpoints just need some adjustment, but then we should be really to rock.

[Kai-Animator]

Thanks for the feedback @tobiasehlert, sorry search and replace all because I though you weren't using TibiaURL in other files. 🙇 Hope this revisions are satisfying.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tobiasehlert]

looks good to me 🌟