Skip to content

Conversation

@judahrand
Copy link
Collaborator

Problem

If you select new tables to add to an existing log based extract, it'll do a "logical_initial" full table sync on those new tables each and every time the tap runs. It'll never switch over to log based replication for them.

Another example of this issue is that if intend to run with break_at_end_lsn is False then I have to run the tap twice - once to perform the initial sync and again to start the logical replication.

Proposed changes

This Pull Request contains changes which are simpler and, I believe, more correct than those in transferwise#130. Both Pull Requests aim to solve transferwise#107.

My changes ensure that whenever a LOG_BASED replication runs the bookmark is initialised correctly and any logical replication which is required is performed.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@judahrand judahrand force-pushed the thread-issue-107 branch 8 times, most recently from 7d260d7 to 5338284 Compare January 18, 2022 13:52
@judahrand judahrand merged commit e931b75 into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants