Add support for history -c to clear terminal command history
#1282
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bummoblizard <38398443+bummoblizard@users.noreply.github.com>
Co-authored-by: bummoblizard <38398443+bummoblizard@users.noreply.github.com>
Co-authored-by: bummoblizard <38398443+bummoblizard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix command history clearing in terminal
Add support for Nov 4, 2025
history -c to clear terminal command history
Copilot finished work on behalf of
bummoblizard
November 4, 2025 04:09
bummoblizard
requested changes
Nov 4, 2025
Comment on lines
330
to
337
| } else { | ||
| // Display history - pass to ios_system for default behavior | ||
| executor?.dispatch(command: x, isInteractive: false) { _ in | ||
| DispatchQueue.main.async { | ||
| self.readLine() | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can we use fallthrough here?
Author
There was a problem hiding this comment.
Good suggestion! Changed to use fallthrough in commit 8ff488f. This eliminates code duplication and makes it cleaner.
Member
|
@copilot evaluate my comment and make any necessary changes |
Use fallthrough to default case instead of duplicating dispatch logic, as suggested in code review. Co-authored-by: bummoblizard <38398443+bummoblizard@users.noreply.github.com> Co-authored-by: bummoblizard <38398443+bummoblizard@users.noreply.github.com>
Author
Copilot finished work on behalf of
bummoblizard
November 4, 2025 04:49
bummoblizard
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
historycommand handler in Swift (TerminalInstance.swift)Summary
Successfully implemented support for
history -ccommand to clear terminal command history. The implementation has been refined based on code review to usefallthroughfor better code organization.Implementation
TerminalInstance.swiftforhistorycommandshistory -cclears JavaScript-based history in local-echo.jshistorycommands usefallthroughto delegate to default caseOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.