Connector now uses a requests Session, can have a pool #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* makes everything nice and async * actually runs teardown * adds a requests session to the connector, with optional Pool parameter * ignore dependency management * getting it back to the initial repo state Co-authored-by: Carrasco <icarrasco@LT-76939.local>
Contributor
|
Hey @igorecarrasco interesting idea! I'll take some time to review the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a requests Session to the connector, allowing the use of a pool and more rational management of HTTP connections.
Adds an extra optional parameter to the connector init method:
poolwill allow users to instantiate larger pools than the default (10, defined at module level). This can be good for multithreaded use.