Add color, image and material classes #831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feat/AddColorImageAndMateriaClass
branch
from
415127d to
8c99c88
Compare
Levi-Armstrong
force-pushed
the
feat/AddColorImageAndMateriaClass
branch
from
8c99c88 to
11cd2e6
Compare
Levi-Armstrong
force-pushed
the
feat/AddColorImageAndMateriaClass
branch
from
11cd2e6 to
d16d103
Compare
Contributor
Author
|
@johnwason Do you think the color and material structures are useful to get integrated? |
Contributor
|
We already have a lot of these capabilities implemented. What do you think is missing? |
Contributor
|
If we are going to add rendering camera sensors as discussed in #1164 we may want to revisit this. I didn't think it was necessary for the viewer. |
Contributor
Author
|
I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are taken from Ignition repository.
Remaining Tasks: