generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: expose Sysdig agent mode as configurable input variable #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jor2
wants to merge
3
commits into
main
Choose a base branch
from
feature/expose-agent-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0a2e1d to
a2b258c
Compare
Member
Author
|
/run pipeline |
ocofaigh
requested changes
Nov 28, 2025
Contributor
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
jor2
pushed a commit
that referenced
this pull request
Nov 28, 2025
Update agent_mode variable descriptions and catalog configuration based on review feedback: - Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction - Simplify variable description and add 'Learn more' documentation link - Add dropdown selection in ibm_catalog.json with valid mode options - Update git submodule to latest version - Auto-generate documentation via pre-commit hooks Addresses review comments from ocofaigh on PR #267 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jor2
pushed a commit
that referenced
this pull request
Nov 28, 2025
Update agent_mode variable descriptions and catalog configuration based on review feedback: - Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction - Simplify variable description and add 'Learn more' documentation link - Add dropdown selection in ibm_catalog.json with valid mode options - Update git submodule to latest version - Auto-generate documentation via pre-commit hooks Addresses review comments from ocofaigh on PR #267
7276b2b to
446a9ea
Compare
Update agent_mode variable descriptions and catalog configuration: - Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction - Simplify variable description and add documentation link - Add dropdown selection in ibm_catalog.json with valid mode options - Update git submodule to latest version Addresses review comments from ocofaigh on PR #267
446a9ea to
cff9c59
Compare
Member
Author
|
/run pipeline |
Add helpful descriptions to each agent_mode option in the catalog configuration to improve user experience when selecting modes.
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
2 similar comments
Member
Author
|
/run pipeline |
Member
Author
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add agent_mode variable to allow users to configure the operational mode of the Sysdig agent. This addresses GitHub issue #263 where users need to set the agent to 'troubleshooting' mode to access additional metrics.
The agent_mode variable accepts:
Fixes issue #263
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers