Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Nov 28, 2025

Description

Add agent_mode variable to allow users to configure the operational mode of the Sysdig agent. This addresses GitHub issue #263 where users need to set the agent to 'troubleshooting' mode to access additional metrics.

The agent_mode variable accepts:

  • 'monitor': Standard monitoring mode
  • 'monitor_light': Lightweight monitoring mode
  • 'troubleshooting': Enhanced mode with additional metrics like HTTP request metrics (sysdig_container_net_http_url_request_count, sysdig_container_net_http_url_request_time, sysdig_container_net_http_url_error_count)
  • null: Use the agent's default mode (default value)

Fixes issue #263

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 requested a review from Aashiq-J as a code owner November 28, 2025 16:24
@jor2 jor2 force-pushed the feature/expose-agent-mode branch from e0a2e1d to a2b258c Compare November 28, 2025 16:28
@jor2
Copy link
Member Author

jor2 commented Nov 28, 2025

/run pipeline

@jor2 jor2 self-assigned this Nov 28, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

jor2 pushed a commit that referenced this pull request Nov 28, 2025
Update agent_mode variable descriptions and catalog configuration based on
review feedback:
- Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction
- Simplify variable description and add 'Learn more' documentation link
- Add dropdown selection in ibm_catalog.json with valid mode options
- Update git submodule to latest version
- Auto-generate documentation via pre-commit hooks

Addresses review comments from ocofaigh on PR #267

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
jor2 pushed a commit that referenced this pull request Nov 28, 2025
Update agent_mode variable descriptions and catalog configuration based on
review feedback:
- Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction
- Simplify variable description and add 'Learn more' documentation link
- Add dropdown selection in ibm_catalog.json with valid mode options
- Update git submodule to latest version
- Auto-generate documentation via pre-commit hooks

Addresses review comments from ocofaigh on PR #267
@jor2 jor2 force-pushed the feature/expose-agent-mode branch 2 times, most recently from 7276b2b to 446a9ea Compare November 28, 2025 22:22
Update agent_mode variable descriptions and catalog configuration:
- Replace 'Sysdig agent' with 'Monitoring agent' for better abstraction
- Simplify variable description and add documentation link
- Add dropdown selection in ibm_catalog.json with valid mode options
- Update git submodule to latest version

Addresses review comments from ocofaigh on PR #267
@jor2 jor2 force-pushed the feature/expose-agent-mode branch from 446a9ea to cff9c59 Compare November 28, 2025 22:26
@jor2
Copy link
Member Author

jor2 commented Nov 28, 2025

/run pipeline

Add helpful descriptions to each agent_mode option in the catalog
configuration to improve user experience when selecting modes.
@jor2
Copy link
Member Author

jor2 commented Nov 28, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 28, 2025

/run pipeline

2 similar comments
@jor2
Copy link
Member Author

jor2 commented Nov 29, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 29, 2025

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants