Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 26, 2025

Description

  • add 3 new functions is_boolean, return_mac_architecture and install_jq

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

fi

# return 0 if jq already installed and skip_if_detected is true
if [ "${skip_if_detected}" == "true" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I guess skip_if_detected logic doesn't seem to work as expected.
if jq is not detected it should install, right?
But this logic doesn't seem to do that, it displays Missing binaries: jq and exits the script.

@ocofaigh ocofaigh merged commit 1a17d11 into main Nov 27, 2025
1 check passed
@ocofaigh ocofaigh deleted the more branch November 27, 2025 12:43
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants