Skip to content

fix(helpers/setup-sa.sh): swap deprecated output cli option #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sambilbow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helpers/setup-sa.sh): swap deprecated output cli option #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions helpers/setup-sa.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ gcloud iam service-accounts \
echo "Downloading key to credentials.json..."
gcloud iam service-accounts keys create "${KEY_FILE}" \
--iam-account "${SA_ID}" \
--user-output-enabled false
--no-user-output-enabled

if [[ $FOLDER_ID == "" ]]; then
echo "Skipping grant roles on project folder... (parameter not passed)"
Expand All @@ -154,7 +154,7 @@ else
"${FOLDER_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/resourcemanager.folderViewer" \
--user-output-enabled false
--no-user-output-enabled
fi

echo "Applying permissions for org $ORG_ID and project $SEED_PROJECT..."
Expand All @@ -164,63 +164,63 @@ gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/resourcemanager.organizationViewer" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/resourcemanager.projectCreator to the service account on the organization
echo "Adding role roles/resourcemanager.projectCreator..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/resourcemanager.projectCreator" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/billing.user to the service account on the organization
echo "Adding role roles/billing.user..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/billing.user" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/billing.viewer to the service account on the organization
echo "Adding role roles/billing.viewer..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/billing.viewer" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/compute.xpnAdmin to the service account on the organization
echo "Adding role roles/compute.xpnAdmin..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/compute.xpnAdmin" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/compute.networkAdmin to the service account on the organization
echo "Adding role roles/compute.networkAdmin..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/compute.networkAdmin" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/iam.serviceAccountAdmin to the service account on the organization
echo "Adding role roles/iam.serviceAccountAdmin..."
gcloud organizations add-iam-policy-binding \
"${ORG_ID}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/iam.serviceAccountAdmin" \
--user-output-enabled false
--no-user-output-enabled

# Grant roles/resourcemanager.projectIamAdmin to the Seed Service Account on the Seed Project
echo "Adding role roles/resourcemanager.projectIamAdmin..."
gcloud projects add-iam-policy-binding \
"${SEED_PROJECT}" \
--member="serviceAccount:${SA_ID}" \
--role="roles/resourcemanager.projectIamAdmin" \
--user-output-enabled false
--no-user-output-enabled

# Enable required API's
echo "Enabling APIs..."
Expand Down Expand Up @@ -254,7 +254,7 @@ if [[ ${BILLING_ACCOUNT:-} != "" ]]; then
gcloud beta billing accounts add-iam-policy-binding "$BILLING_ACCOUNT" \
--member="serviceAccount:${SA_ID}" \
--role="roles/billing.user" \
--user-output-enabled false
--no-user-output-enabled
fi

echo "All done."