docs: fix favicon for modern browsers #537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds favicon support to the VuePress documentation site by introducing favicon files and updating the configuration to reference them.
- Added favicon.svg and favicon.png files to the public directory
- Configured favicon links in the VuePress config for various browsers and devices
Reviewed Changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/.vuepress/public/favicon.svg | New SVG favicon file with the Taskiq logo |
| docs/.vuepress/public/favicon.png | New PNG favicon file for Apple touch icon support |
| docs/.vuepress/config.ts | Added three link tags to configure favicon.ico, favicon.svg, and apple-touch-icon |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added favicon for modern browsers in svg format and added favicon in png format for apple mobile devices.
Without this fix my browser (Google Chrome) doesn't show favicon on documentation site.
Preview with / without fix
