Skip to content

feat: add ability to specify the default WorkerArgs … #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add ability to specify the default WorkerArgs … #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions taskiq/cli/worker/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from argparse import ArgumentDefaultsHelpFormatter, ArgumentParser
from argparse import ArgumentDefaultsHelpFormatter, ArgumentParser, Namespace
from dataclasses import dataclass, field
from typing import List, Optional, Sequence, Tuple
from typing import Any, Dict, List, Optional, Sequence, Tuple

from taskiq.acks import AcknowledgeType
from taskiq.cli.common_args import LogLevel
Expand Down Expand Up @@ -58,11 +58,13 @@ class WorkerArgs:
def from_cli(
cls,
args: Optional[Sequence[str]] = None,
defaults: Optional[Dict[str, Any]] = None,
) -> "WorkerArgs":
"""
Construct TaskiqArgs instanc from CLI arguments.

:param args: list of args as for cli.
:param defaults: default worker arguments.
:return: TaskiqArgs instance.
"""
parser = ArgumentParser(formatter_class=ArgumentDefaultsHelpFormatter)
Expand Down Expand Up @@ -267,7 +269,10 @@ def from_cli(
help="Maximum number of processes in process pool.",
)

namespace = parser.parse_args(args)
namespace = parser.parse_args(
args,
namespace=None if defaults is None else Namespace(**defaults),
)
# If there are any patterns specified, remove default.
# This is an argparse limitation.
if len(namespace.tasks_pattern) > 1:
Expand Down