pushAPI: remove box.session.push usage #494
Conversation
Removed `box.session.push()` usage: `Future.AppendPush()`, `Future.GetIterator()` methods, `ResponseIterator` and `TimeoutResponseIterator` types, `pushes[]` field in `Future` and related methods. Removed tests which became unnecessary. Closes #480
laines-it
changed the title
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Please, rebase on the master branch and re-format the commit message (update prefix and just to make it look better):
api: removed deprecated methods
Removed `box.session.push()` usage:
* `Future.AppendPush()`, `Future.GetIterator()` methods;
* `ResponseIterator` and `TimeoutResponseIterator` types;
* `pushes[]` field in `Future` and related methods.
Closes #480
Also, it would be a good idea to clean up here:
Lines 177 to 183 in 802aa24
| conn.opts.Logger.Report(LogAppendPushFailed, conn, err) | ||
| } | ||
| } | ||
| // not implemented |
There was a problem hiding this comment.
Nit: we need to add a log message here, something like:
unexpected IPTOTO_CHUNK for request %d, box.session.push is unsupported
and a test for it.
There was a problem hiding this comment.
After removing Lua push_func, the IPROTO_CHUNK occurrence is no longer possible. Maybe we need to completely remove IPROTO_CHUNK mention? (furthermore, I've already written in changelog.md that I deleted it)
| * `box.New` returns an error instead of panic | ||
| * Added `box.MustNew` wrapper for `box.New` without an error | ||
| * Removed deprecated `pool` methods, related interfaces and tests are updated. | ||
| * Removed `box.session.push()` usage: Future.AppendPush() and Future.GetIterator() |
There was a problem hiding this comment.
| * Removed `box.session.push()` usage: Future.AppendPush() and Future.GetIterator() | |
| * Removed `box.session.push()` support: Future.AppendPush() and Future.GetIterator() |
| * Now cases of `<-ctx.Done()` returns wrapped error provided by `ctx.Cause()`. | ||
| Allows you compare it using `errors.Is/As` (#457). | ||
| * Removed deprecated `pool` methods, related interfaces and tests are updated (#478). | ||
| * Removed deprecated `box.session.push()` usage: Future.AppendPush() |
There was a problem hiding this comment.
| * Removed deprecated `box.session.push()` usage: Future.AppendPush() | |
| * Removed deprecated `box.session.push()` support: Future.AppendPush() |
Removed
box.session.push()usage:Future.AppendPush(),Future.GetIterator()methods,ResponseIteratorandTimeoutResponseIteratortypes,pushes[]field inFutureand related methods.Removed tests which became unnecessary.
I didn't forget about (remove if it is not applicable):
Closes #480