[feat]: Add functionality to delete a wish #8
Conversation
| const [isOpen, setIsOpen] = createSignal(false); | ||
|
|
||
| const handleDeleteItem = ()=>{ | ||
| props.setItems((items) => { |
There was a problem hiding this comment.
As the issue talks about deleting one or more wishes.. it is better to add a delete link at the top of the wish list.. it will help us to select one or more wishes and then click on the single delete button.
the modal looks good.
There was a problem hiding this comment.
Apologies for not being able to implement the desired feature initially. Could you please confirm if I understand correctly? You're suggesting adding a delete button at the top of the wishlist. Users can then select multiple items and delete them with a single click. If my interpretation is incorrect, please provide clarification. Thank you for your feedback.
There was a problem hiding this comment.
Sir @atapas, I've implemented the feature. Please check the attached video. If it looks good, I'll proceed with the changes. Any feedback is welcome.
2023-11-15-06-35-02.mp4
|
@Mohimkhan Please resolve the merge conflicts |
|
@atapas Sir, I haven't committed my changes yet. I will look into this and resolve the conflicts. |
@atapas Sir, I have gone through evey confilcts and I think i can resolve them but it might take some time as I have to rewrite the css in tailwind and also some other things. Iam working on it |
Try to create a separate branch and start work with it will help you to avoid conflict |
Thank you @sarowarhosen03 but I have already fetch the changes to my current branch (feat/functionality-to-delete-a-wish) and also solve 2 conflicts, now i just have to rewrite the css to tailwind and also check if deleteing a wish makes changes in localstorage |
#19 if this PR merged you don't need to do anything for deleting or updating items on localstorage . Just update the main state it will automatically update on localstorage |
so should i wait for it to merge or I can do the other things and I will not do anything to delete items in localStorage but if i can finished my work and it didn't get merge then i will do what ever necessay. I have gone through your changes and i think the only conflicting files for me after you PR get merge will be (AddToBucket, BucketList, App) . I think the conflicts will be small if any of our PR gets merged. Whats your thought on this |
Yes you're right. Let's see which pr got merge first |
You can work on a separate branch. In future if you need to pull something on your main branch. You can fix the merge conflict locally |
✅ Deploy Preview for solidbucketlist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@atapas Sir, I have resolve all the conflicts. please check if it needs anything |
3 participants
What does this PR do?
This PR adds functionality to delete a wish with confirmation
fixes #2
How to test?
Screenshots or Videos
2023-11-12-21-22-44.mp4
Type of change
How should this be tested?