Skip to content

lift Clone constraint on type H #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwy15 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lift Clone constraint on type H #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d18bf3
lift clone constraint on H
Oct 23, 2025
03f8aac
also for HLL+
Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/hyperloglog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ use crate::HyperLogLogError;
/// algorithm", Philippe Flajolet, Éric Fusy, Olivier Gandouet and Frédéric
/// Meunier.](http://algo.inria.fr/flajolet/Publications/FlFuGaMe07.pdf)
///
#[derive(Clone, Debug, Serialize, Deserialize)]
#[derive(Debug, Serialize, Deserialize)]
pub struct HyperLogLogPF<H, B>
where
H: Hash + ?Sized,
Expand All @@ -54,6 +54,22 @@ where
phantom: PhantomData<H>,
}

impl<H, B> Clone for HyperLogLogPF<H, B>
where
H: Hash + ?Sized,
B: BuildHasher + Clone,
{
fn clone(&self) -> Self {
Self {
builder: self.builder.clone(),
count: self.count,
precision: self.precision,
registers: self.registers.clone(),
phantom: self.phantom,
}
}
}

impl<H, B> HyperLogLogPF<H, B>
where
H: Hash + ?Sized,
Expand Down
20 changes: 19 additions & 1 deletion src/hyperloglogplus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ use crate::HyperLogLogError;
/// of the Art Cardinality Estimation Algorithm", Stefan Heule, Marc
/// Nunkesser and Alexander Hall.](https://goo.gl/iU8Ig)
///
#[derive(Clone, Debug, Serialize, Deserialize)]
#[derive(Debug, Serialize, Deserialize)]
pub struct HyperLogLogPlus<H, B>
where
H: Hash + ?Sized,
Expand All @@ -68,6 +68,24 @@ where
phantom: PhantomData<H>,
}

impl<H, B> Clone for HyperLogLogPlus<H, B>
where
H: Hash + ?Sized,
B: BuildHasher + Clone,
{
fn clone(&self) -> Self {
Self {
builder: self.builder.clone(),
precision: self.precision,
counts: self.counts,
tmpset: self.tmpset.clone(),
sparse: self.sparse.clone(),
registers: self.registers.clone(),
phantom: self.phantom,
}
}
}

impl<H, B> HyperLogLogPlus<H, B>
where
H: Hash + ?Sized,
Expand Down