Add make format target

[ChinYikMing]

Description

• Add make format target for easier formatting for developers.
• Intruduce version checking utils: version_{eq, lt, lte, gt, gte} and refactor with them for tools: emcc, browsers(Chrome, Firefox, Safari), black
• Update CONTRIBUTING.md to reflect the make format target

---

Summary by cubic

Adds a make format target to auto-format C/C++, shell, and Python, and introduces version-compare helpers to simplify build-time checks. This streamlines developer formatting and reduces brittle version logic.

• New Features

  • make format runs clang-format, shfmt, and black; skips submodules and OUT.
  • Validates tool presence and versions (clang-format 18, shfmt, black 25.1.0+), with helpful warnings.
  • CONTRIBUTING.md updated to document the new command.

• Refactors

  • Added version_{eq,lt,lte,gt,gte} helpers in mk/common.mk.
  • Replaced nested bc checks in mk/toolchain.mk and mk/wasm.mk:
    • SDL music: warn unless emcc == 3.1.51.
    • Enable mimalloc when emcc >= 3.1.50.
    • TCO checks: Chrome/Firefox by major version, Safari >= 18.2.

^{Written for commit b1ba59b. Summary will update automatically on new commits.}

[cubic-dev-ai]

4 issues found across 5 files

Prompt for AI agents (all 4 issues)

Understand the root cause of the following 4 issues and fix them.


<file name="mk/wasm.mk">

<violation number="1" location="mk/wasm.mk:86">
By splitting the Safari requirement into major/minor constants without also defining SAFARI_SUPPORT_TCO_AT_MAJOR_MINOR (or updating the warning string), the warning now expands to an empty version number, leaving developers without the Safari version requirement.</violation>
</file>

<file name="Makefile">

<violation number="1" location="Makefile:497">
Guard the black version query so it isn’t executed when black is absent, otherwise every make invocation emits `/bin/sh: 1: --version: not found`.</violation>

<violation number="2" location="Makefile:508">
Ensure the generated prune expression always has a left-hand operand; when SUBMODULES is empty the current command becomes `find . ( -o … )` and fails.</violation>

<violation number="3" location="Makefile:515">
Failures in formatters are suppressed. The formatting commands are wrapped in `$(shell ...)` which prevents `make` from seeing their exit codes. If a formatter fails, the `make format` target will not fail, leading developers to believe formatting was successful when it was not. The commands should be executed directly, not inside `$(shell ...)`, so that `make` can properly handle their failure.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[jserv]

It is a known issue that clang-format versions 18 and 20+ produce inconsistent indentation, which prevents us from standardizing the formatter version across developers.

[ChinYikMing]

It is a known issue that clang-format versions 18 and 20+ produce inconsistent indentation, which prevents us from standardizing the formatter version across developers.

Since clang-format-18 is still used in check-format.sh, we can stick with clang-format-18 for now IIUC?

[jserv]

Since clang-format-18 is still use in check-format.sh, we can stick with clang-format-18 for now IIUC?

Yes, it is specific to clang-format-18 for preferable indention.

[ChinYikMing]

Got it, I would then remove the comment and force to use clang-format-18 instead.

[ChinYikMing]

The CONTRIBUTING.md is also modified to use clang-format-18 forcibly.