Merge branch '5.4' into 6.0

* 5.4:
  [Security] update Voter return type
  [DependecyInjection] Added Uses & hints
  "Creating Pages" not responsive
  [Cache] Add return hint
  [Cache] Add use Response & return hint
  Update questionhelper.rst
  Minor
  [Cache] Add return hint
  [4.4] fix code sample to log out
  [Lock] Specify default ttl

Author: xabbuh

components/console/helpers/questionhelper.rst

@@ -88,7 +88,7 @@ if you want to know a bundle name, you can add this to your command::
         
         // ... do something with the bundleName
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 The user will be asked "Please enter the name of the bundle". They can type
@@ -124,7 +124,7 @@ from a predefined list::
 
         // ... do something with the color
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 The option which should be selected by default is provided with the third
@@ -162,7 +162,7 @@ this use :method:`Symfony\\Component\\Console\\Question\\ChoiceQuestion::setMult
         $colors = $helper->ask($input, $output, $question);
         $output->writeln('You have just selected: ' . implode(', ', $colors));
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 Now, when the user enters ``1,2``, the result will be:
@@ -193,7 +193,7 @@ will be autocompleted as the user types::
         
         // ... do something with the bundleName
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 In more complex use cases, it may be necessary to generate suggestions on the
@@ -232,7 +232,7 @@ provide a callback function to dynamically generate suggestions::
         
         // ... do something with the filePath
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 Do not Trim the Answer
@@ -256,7 +256,7 @@ You can also specify if you want to not trim the answer by setting it directly w
         
         // ... do something with the name
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 Accept Multiline Answers
@@ -282,7 +282,7 @@ the response to a question should allow multiline answers by passing ``true`` to
         
         // ... do something with the answer
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 Multiline questions stop reading user input after receiving an end-of-transmission
@@ -310,7 +310,7 @@ convenient for passwords::
         
         // ... do something with the password
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 .. caution::
@@ -342,7 +342,7 @@ convenient for passwords::
 
             // ...
             
-            return Commande::SUCCESS;
+            return Command::SUCCESS;
         }
 
 Normalizing the Answer
@@ -373,7 +373,7 @@ method::
         
         // ... do something with the bundleName
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 .. caution::
@@ -417,7 +417,7 @@ method::
         
         // ... do something with the bundleName
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 The ``$validator`` is a callback which handles the validation. It should
@@ -479,7 +479,7 @@ You can also use a validator with a hidden question::
         
         // ... do something with the password
         
-        return Commande::SUCCESS;
+        return Command::SUCCESS;
     }
 
 Testing a Command that Expects Input

components/lock.rst

@@ -144,7 +144,7 @@ job; if it's too long and the process crashes before calling the ``release()``
 method, the resource will stay locked until the timeout::
 
     // ...
-    // create an expiring lock that lasts 30 seconds
+    // create an expiring lock that lasts 30 seconds (default is 300.0)
     $lock = $factory->createLock('charts-generation', 30);
 
     if (!$lock->acquire()) {

deployment.rst

@@ -227,7 +227,7 @@ setup:
 * Pushing assets to a CDN
 * On a shared hosting platform using the Apache web server, you may need to
   install the :ref:`symfony/apache-pack package <web-server-apache-mod-php>`
-* ...
+* etc.
 
 Application Lifecycle: Continuous Integration, QA, etc.
 -------------------------------------------------------

http_cache.rst

@@ -215,7 +215,7 @@ The *easiest* way to cache a response is by caching it for a specific amount of
     use Symfony\Component\HttpFoundation\Response;
     // ...
 
-    public function index()
+    public function index(): Response
     {
         // somehow create a Response object, like by rendering a template
         $response = $this->render('blog/index.html.twig', []);

http_cache/esi.rst

@@ -106,7 +106,7 @@ independently of the rest of the page::
     // ...
     class DefaultController extends AbstractController
     {
-        public function about()
+        public function about(): Response
         {
             $response = $this->render('static/about.html.twig');
             $response->setPublic();
@@ -172,7 +172,7 @@ of the main page::
     // ...
     class NewsController extends AbstractController
     {
-        public function latest($maxPerPage)
+        public function latest(int $maxPerPage): Response
         {
             // sets to public and adds some expiration
             $response->setSharedMaxAge(60);

http_cache/validation.rst

@@ -56,10 +56,11 @@ content::
 
     use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
     use Symfony\Component\HttpFoundation\Request;
+    use Symfony\Component\HttpFoundation\Response;
 
     class DefaultController extends AbstractController
     {
-        public function homepage(Request $request)
+        public function homepage(Request $request): Response
         {
             $response = $this->render('static/homepage.html.twig');
             $response->setEtag(md5($response->getContent()));
@@ -138,7 +139,7 @@ header value::
 
     class ArticleController extends AbstractController
     {
-        public function show(Article $article, Request $request)
+        public function show(Article $article, Request $request): Response
         {
             $author = $article->getAuthor();
 
@@ -196,7 +197,7 @@ the better. The ``Response::isNotModified()`` method does exactly that::
 
     class ArticleController extends AbstractController
     {
-        public function show($articleSlug, Request $request)
+        public function show(string $articleSlug, Request $request): Response
         {
             // Get the minimum information to compute
             // the ETag or the Last-Modified value

page_creation.rst

@@ -166,11 +166,13 @@ To get a list of *all* of the routes in your system, use the ``debug:router`` co
 
 You should see your ``app_lucky_number`` route in the list:
 
-================== ======== ======== ====== ===============
-Name               Method   Scheme   Host   Path
-================== ======== ======== ====== ===============
-app_lucky_number   ANY      ANY      ANY    /lucky/number
-================== ======== ======== ====== ===============
+.. code-block:: terminal
+
+    ----------------  -------  -------  -----  --------------
+    Name              Method   Scheme   Host   Path
+    ----------------  -------  -------  -----  --------------
+    app_lucky_number  ANY      ANY      ANY    /lucky/number
+    ----------------  -------  -------  -----  --------------
 
 You will also see debugging routes besides ``app_lucky_number`` -- more on
 the debugging routes in the next section.

security/form_login.rst

@@ -8,9 +8,6 @@ The form login authenticator creates a login form where users authenticate
 using an identifier (e.g. email address or username) and a password. In
 :ref:`security-form-login` the usage of this authenticator is explained.
 
-This article describes how to customize the responses (success or failure)
-of this authenticator.
-
 Redirecting after Success
 -------------------------
 

security/voters.rst

@@ -47,8 +47,8 @@ which makes creating a voter even easier::
 
     abstract class Voter implements VoterInterface
     {
-        abstract protected function supports(string $attribute, mixed $subject);
-        abstract protected function voteOnAttribute(string $attribute, mixed $subject, TokenInterface $token);
+        abstract protected function supports(string $attribute, mixed $subject): bool;
+        abstract protected function voteOnAttribute(string $attribute, mixed $subject, TokenInterface $token): bool;
     }
 
 .. _how-to-use-the-voter-in-a-controller:

service_container.rst

@@ -368,7 +368,7 @@ you can type-hint the new ``SiteUpdateManager`` class and use it::
 
     class SiteController extends AbstractController
     {
-        public function new(SiteUpdateManager $siteUpdateManager)
+        public function new(SiteUpdateManager $siteUpdateManager): Response
         {
             // ...