Merge branch '4.4' into 5.4

* 4.4:
  [Security] update Voter return type
  [DependecyInjection] Added Uses & hints
  "Creating Pages" not responsive
  [Cache] Add return hint
  [Cache] Add use Response & return hint
  Minor
  [4.4] fix code sample to log out
  [Lock] Specify default ttl

Author: xabbuh

components/lock.rst

@@ -152,7 +152,7 @@ job; if it's too long and the process crashes before calling the ``release()``
 method, the resource will stay locked until the timeout::
 
     // ...
-    // create an expiring lock that lasts 30 seconds
+    // create an expiring lock that lasts 30 seconds (default is 300.0)
     $lock = $factory->createLock('charts-generation', 30);
 
     if (!$lock->acquire()) {

deployment.rst

@@ -213,7 +213,7 @@ setup:
 * Pushing assets to a CDN
 * On a shared hosting platform using the Apache web server, you may need to
   install the :ref:`symfony/apache-pack package <web-server-apache-mod-php>`
-* ...
+* etc.
 
 Application Lifecycle: Continuous Integration, QA, etc.
 -------------------------------------------------------

http_cache/esi.rst

@@ -106,7 +106,7 @@ independently of the rest of the page::
     // ...
     class DefaultController extends AbstractController
     {
-        public function about()
+        public function about(): Response
         {
             $response = $this->render('static/about.html.twig');
             $response->setPublic();
@@ -172,7 +172,7 @@ of the main page::
     // ...
     class NewsController extends AbstractController
     {
-        public function latest($maxPerPage)
+        public function latest(int $maxPerPage): Response
         {
             // sets to public and adds some expiration
             $response->setSharedMaxAge(60);

http_cache/validation.rst

@@ -56,10 +56,11 @@ content::
 
     use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
     use Symfony\Component\HttpFoundation\Request;
+    use Symfony\Component\HttpFoundation\Response;
 
     class DefaultController extends AbstractController
     {
-        public function homepage(Request $request)
+        public function homepage(Request $request): Response
         {
             $response = $this->render('static/homepage.html.twig');
             $response->setEtag(md5($response->getContent()));
@@ -138,7 +139,7 @@ header value::
 
     class ArticleController extends AbstractController
     {
-        public function show(Article $article, Request $request)
+        public function show(Article $article, Request $request): Response
         {
             $author = $article->getAuthor();
 
@@ -196,7 +197,7 @@ the better. The ``Response::isNotModified()`` method does exactly that::
 
     class ArticleController extends AbstractController
     {
-        public function show($articleSlug, Request $request)
+        public function show(string $articleSlug, Request $request): Response
         {
             // Get the minimum information to compute
             // the ETag or the Last-Modified value

page_creation.rst

@@ -184,11 +184,13 @@ To get a list of *all* of the routes in your system, use the ``debug:router`` co
 
 You should see your ``app_lucky_number`` route in the list:
 
-================== ======== ======== ====== ===============
-Name               Method   Scheme   Host   Path
-================== ======== ======== ====== ===============
-app_lucky_number   ANY      ANY      ANY    /lucky/number
-================== ======== ======== ====== ===============
+.. code-block:: terminal
+
+    ----------------  -------  -------  -----  --------------
+    Name              Method   Scheme   Host   Path
+    ----------------  -------  -------  -----  --------------
+    app_lucky_number  ANY      ANY      ANY    /lucky/number
+    ----------------  -------  -------  -----  --------------
 
 You will also see debugging routes besides ``app_lucky_number`` -- more on
 the debugging routes in the next section.

security/form_login.rst

@@ -8,9 +8,6 @@ The form login authenticator creates a login form where users authenticate
 using an identifier (e.g. email address or username) and a password. In
 :ref:`security-form-login` the usage of this authenticator is explained.
 
-This article describes how to customize the responses (success or failure)
-of this authenticator.
-
 Redirecting after Success
 -------------------------
 

security/voters.rst

@@ -47,8 +47,8 @@ which makes creating a voter even easier::
 
     abstract class Voter implements VoterInterface
     {
-        abstract protected function supports(string $attribute, $subject);
-        abstract protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token);
+        abstract protected function supports(string $attribute, $subject) bool;
+        abstract protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool;
     }
 
 .. _how-to-use-the-voter-in-a-controller:

service_container.rst

@@ -374,7 +374,7 @@ you can type-hint the new ``SiteUpdateManager`` class and use it::
 
     class SiteController extends AbstractController
     {
-        public function new(SiteUpdateManager $siteUpdateManager)
+        public function new(SiteUpdateManager $siteUpdateManager): Response
         {
             // ...